[SCSI] be2iscsi: Fix for a possible udelay while holding lock

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Thursday, March 18, 2010 - 6:00 pm

Gitweb:     http://git.kernel.org/linus/944b2fbce26ce39555363fd092386807fa5ea08c
Commit:     944b2fbce26ce39555363fd092386807fa5ea08c
Parent:     4183122dbc7c489f11971c5afa8e42011bca7fa2
Author:     Jayamohan Kallickal <jayamohank@serverengines.com>
AuthorDate: Sat Feb 20 08:03:24 2010 +0530
Committer:  James Bottomley <James.Bottomley@suse.de>
CommitDate: Wed Mar 3 17:40:04 2010 +0530

    [SCSI] be2iscsi: Fix for a possible udelay while holding lock
    
    This patch fixes a situation where we could call udelay
    while holding spin_lock
    
    Signed-off-by: Jayamohan Kallickal <jayamohank@serverengines.com>
    Signed-off-by: James Bottomley <James.Bottomley@suse.de>
---
 drivers/scsi/be2iscsi/be_cmds.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c
index 6709857..cda6642 100644
--- a/drivers/scsi/be2iscsi/be_cmds.c
+++ b/drivers/scsi/be2iscsi/be_cmds.c
@@ -32,18 +32,11 @@ void be_mcc_notify(struct beiscsi_hba *phba)
 unsigned int alloc_mcc_tag(struct beiscsi_hba *phba)
 {
 	unsigned int tag = 0;
-	unsigned int num = 0;
 
-mcc_tag_rdy:
 	if (phba->ctrl.mcc_tag_available) {
 		tag = phba->ctrl.mcc_tag[phba->ctrl.mcc_alloc_index];
 		phba->ctrl.mcc_tag[phba->ctrl.mcc_alloc_index] = 0;
 		phba->ctrl.mcc_numtag[tag] = 0;
-	} else {
-		udelay(100);
-		num++;
-		if (num < mcc_timeout)
-			goto mcc_tag_rdy;
 	}
 	if (tag) {
 		phba->ctrl.mcc_tag_available--;
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[SCSI] be2iscsi: Fix for a possible udelay while holding lock, Linux Kernel Mailing ..., (Thu Mar 18, 6:00 pm)