pcmcia: fix incorrect argument order to list_add_tail()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Wednesday, September 16, 2009 - 8:59 am

Gitweb:     http://git.kernel.org/linus/b4b3d7bbe1e1d924dc5f3b48b6c06977aee2d494
Commit:     b4b3d7bbe1e1d924dc5f3b48b6c06977aee2d494
Parent:     d598de02187e4de89595537f69dffe8334f9a066
Author:     Wolfram Sang <w.sang@pengutronix.de>
AuthorDate: Mon Jul 20 10:58:59 2009 +0200
Committer:  Greg Kroah-Hartman <gregkh@suse.de>
CommitDate: Tue Sep 15 10:17:16 2009 -0700

    pcmcia: fix incorrect argument order to list_add_tail()
    
    Commit a56bc69a182f501582557af7fad5bc882b1c856c fixed a wrong usage of
    list_add_tail() within store_new_id() for PCI. Port the fix to PCMCIA,
    which adapted this function from PCI.
    
    Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
    Cc: Dominik Brodowski <linux@dominikbrodowski.net>
    Cc: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/pcmcia/ds.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/pcmcia/ds.c b/drivers/pcmcia/ds.c
index 304ff6d..9f300d3 100644
--- a/drivers/pcmcia/ds.c
+++ b/drivers/pcmcia/ds.c
@@ -236,7 +236,6 @@ pcmcia_store_new_id(struct device_driver *driver, const char *buf, size_t count)
 	if (!dynid)
 		return -ENOMEM;
 
-	INIT_LIST_HEAD(&dynid->node);
 	dynid->id.match_flags = match_flags;
 	dynid->id.manf_id = manf_id;
 	dynid->id.card_id = card_id;
@@ -246,7 +245,7 @@ pcmcia_store_new_id(struct device_driver *driver, const char *buf, size_t count)
 	memcpy(dynid->id.prod_id_hash, prod_id_hash, sizeof(__u32) * 4);
 
 	spin_lock(&pdrv->dynids.lock);
-	list_add_tail(&pdrv->dynids.list, &dynid->node);
+	list_add_tail(&dynid->node, &pdrv->dynids.list);
 	spin_unlock(&pdrv->dynids.lock);
 
 	if (get_driver(&pdrv->drv)) {
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
pcmcia: fix incorrect argument order to list_add_tail(), Linux Kernel Mailing ..., (Wed Sep 16, 8:59 am)