x86/PCI: pci quirks, fix pci refcounting

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Wednesday, September 16, 2009 - 8:00 am

Gitweb:     http://git.kernel.org/linus/748df9a4c65625c386674c9b54dde73de6cc5af5
Commit:     748df9a4c65625c386674c9b54dde73de6cc5af5
Parent:     28760489a3f1e136c5ae8581c0fa8f63511f2f4c
Author:     Jiri Slaby <jirislaby@gmail.com>
AuthorDate: Tue Sep 8 12:16:18 2009 +0200
Committer:  Jesse Barnes <jbarnes@virtuousgeek.org>
CommitDate: Wed Sep 9 14:11:02 2009 -0700

    x86/PCI: pci quirks, fix pci refcounting
    
    Stanse found a pci reference leak in quirk_amd_nb_node.
    Instead of putting nb_ht, there is a put of dev passed as
    an argument.
    
    http://stanse.fi.muni.cz/
    
    Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
    Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 arch/x86/kernel/quirks.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c
index af71d06..6c3b2c6 100644
--- a/arch/x86/kernel/quirks.c
+++ b/arch/x86/kernel/quirks.c
@@ -508,7 +508,7 @@ static void __init quirk_amd_nb_node(struct pci_dev *dev)
 
 	pci_read_config_dword(nb_ht, 0x60, &val);
 	set_dev_node(&dev->dev, val & 7);
-	pci_dev_put(dev);
+	pci_dev_put(nb_ht);
 }
 
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_K8_NB,
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
x86/PCI: pci quirks, fix pci refcounting, Linux Kernel Mailing ..., (Wed Sep 16, 8:00 am)