nfs41: use nfs4_getaclres

Previous thread: NFSD: Finish refactoring __write_ports() by Linux Kernel Mailing List on Monday, June 22, 2009 - 2:05 pm. (1 message)

Next thread: NFSD: Stricter buffer size checking in write_recoverydir() by Linux Kernel Mailing List on Monday, June 22, 2009 - 2:05 pm. (1 message)
From: Linux Kernel Mailing List
Date: Monday, June 22, 2009 - 2:02 pm

Gitweb:     http://git.kernel.org/linus/663c79b3cd8f5fe21fe7d7565fec0072e3234ddc
Commit:     663c79b3cd8f5fe21fe7d7565fec0072e3234ddc
Parent:     d45b2989a7956ae9e71d584ceac942278c0371c7
Author:     Benny Halevy <bhalevy@panasas.com>
AuthorDate: Wed Apr 1 09:21:59 2009 -0400
Committer:  Benny Halevy <bhalevy@panasas.com>
CommitDate: Wed Jun 17 10:46:25 2009 -0700

    nfs41: use nfs4_getaclres
    
    In preparation for nfs41 sequence processing.
    
    Signed-off-by: Andy Admason <andros@netapp.com>
    Signed-off-by: Benny Halevy <bhalevy@panasas.com>
    [nfs41: embed resp_len in nfs_getaclres]
    Signed-off-by: Benny Halevy <bhalevy@panasas.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
---
 fs/nfs/nfs4proc.c       |   20 +++++++++++---------
 fs/nfs/nfs4xdr.c        |    5 +++--
 include/linux/nfs_xdr.h |    5 +++++
 3 files changed, 19 insertions(+), 11 deletions(-)

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index aea2e83..20c9acf 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -2755,12 +2755,14 @@ static ssize_t __nfs4_get_acl_uncached(struct inode *inode, void *buf, size_t bu
 		.acl_pages = pages,
 		.acl_len = buflen,
 	};
-	size_t resp_len = buflen;
+	struct nfs_getaclres res = {
+		.acl_len = buflen,
+	};
 	void *resp_buf;
 	struct rpc_message msg = {
 		.rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_GETACL],
 		.rpc_argp = &args,
-		.rpc_resp = &resp_len,
+		.rpc_resp = &res,
 	};
 	struct page *localpage = NULL;
 	int ret;
@@ -2774,7 +2776,7 @@ static ssize_t __nfs4_get_acl_uncached(struct inode *inode, void *buf, size_t bu
 			return -ENOMEM;
 		args.acl_pages[0] = localpage;
 		args.acl_pgbase = 0;
-		resp_len = args.acl_len = PAGE_SIZE;
+		args.acl_len = PAGE_SIZE;
 	} else {
 		resp_buf = buf;
 		buf_to_pages(buf, buflen, args.acl_pages, &args.acl_pgbase);
@@ -2782,18 +2784,18 @@ static ssize_t __nfs4_get_acl_uncached(struct inode *inode, void *buf, size_t bu
 	ret = ...
Previous thread: NFSD: Finish refactoring __write_ports() by Linux Kernel Mailing List on Monday, June 22, 2009 - 2:05 pm. (1 message)

Next thread: NFSD: Stricter buffer size checking in write_recoverydir() by Linux Kernel Mailing List on Monday, June 22, 2009 - 2:05 pm. (1 message)