do_wait: kill the old BUG_ON, use while_each_thread()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Thursday, June 18, 2009 - 3:00 pm

Gitweb:     http://git.kernel.org/linus/a3f6dfb7295facb0505b5beca5a7ce48b0612379
Commit:     a3f6dfb7295facb0505b5beca5a7ce48b0612379
Parent:     64a16caf5e3417ee32f670debcb5857b02a9e08e
Author:     Oleg Nesterov <oleg@redhat.com>
AuthorDate: Wed Jun 17 16:27:41 2009 -0700
Committer:  Linus Torvalds <torvalds@linux-foundation.org>
CommitDate: Thu Jun 18 13:03:53 2009 -0700

    do_wait: kill the old BUG_ON, use while_each_thread()
    
    do_wait() does BUG_ON(tsk->signal != current->signal), this looks like a
    raher obsolete check.  At least, I don't think do_wait() is the best place
    to verify that all threads have the same ->signal.  Remove it.
    
    Also, change the code to use while_each_thread().
    
    Signed-off-by: Oleg Nesterov <oleg@redhat.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Acked-by: Roland McGrath <roland@redhat.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---
 kernel/exit.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/kernel/exit.c b/kernel/exit.c
index 9c6881a..dd83c84 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -1595,9 +1595,7 @@ repeat:
 
 		if (wo->wo_flags & __WNOTHREAD)
 			break;
-		tsk = next_thread(tsk);
-		BUG_ON(tsk->signal != current->signal);
-	} while (tsk != current);
+	} while_each_thread(current, tsk);
 	read_unlock(&tasklist_lock);
 
 notask:
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
do_wait: kill the old BUG_ON, use while_each_thread(), Linux Kernel Mailing ..., (Thu Jun 18, 3:00 pm)