Blackfin: push access_ok() L1 attribute down

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Friday, June 12, 2009 - 2:00 pm

Gitweb:     http://git.kernel.org/linus/a43b739f257fd2569e11c6c93fbb86df382848e9
Commit:     a43b739f257fd2569e11c6c93fbb86df382848e9
Parent:     8d0d8f2a3a57479b695a59ed2f67236f1488b90d
Author:     Mike Frysinger <vapier@gentoo.org>
AuthorDate: Thu Jun 4 19:24:31 2009 +0000
Committer:  Mike Frysinger <vapier@gentoo.org>
CommitDate: Fri Jun 12 06:12:05 2009 -0400

    Blackfin: push access_ok() L1 attribute down
    
    There is no need for the L1 attribute to be on the prototype of the
    access_ok() function as all consumers of the function do not care where it
    lives -- they'll always use pcrel calls to get to it.  This prevents
    pointless recompiles of most of the system when this config option changes.
    
    Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 arch/blackfin/include/asm/uaccess.h |    4 ----
 arch/blackfin/kernel/process.c      |    3 +++
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/arch/blackfin/include/asm/uaccess.h b/arch/blackfin/include/asm/uaccess.h
index 01f42b0..8894e9f 100644
--- a/arch/blackfin/include/asm/uaccess.h
+++ b/arch/blackfin/include/asm/uaccess.h
@@ -59,12 +59,8 @@ static inline int is_in_rom(unsigned long addr)
 #ifndef CONFIG_ACCESS_CHECK
 static inline int _access_ok(unsigned long addr, unsigned long size) { return 1; }
 #else
-#ifdef CONFIG_ACCESS_OK_L1
-extern int _access_ok(unsigned long addr, unsigned long size)__attribute__((l1_text));
-#else
 extern int _access_ok(unsigned long addr, unsigned long size);
 #endif
-#endif
 
 /*
  * The exception table consists of pairs of addresses: the first is the
diff --git a/arch/blackfin/kernel/process.c b/arch/blackfin/kernel/process.c
index e040e03..30d0843 100644
--- a/arch/blackfin/kernel/process.c
+++ b/arch/blackfin/kernel/process.c
@@ -322,6 +322,9 @@ void finish_atomic_sections (struct pt_regs *regs)
 }
 
 #if defined(CONFIG_ACCESS_CHECK)
+#ifdef CONFIG_ACCESS_OK_L1
+__attribute__((l1_text))
+#endif
 /* Return 1 if access to memory range is OK, 0 otherwise */
 int _access_ok(unsigned long addr, unsigned long size)
 {
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Blackfin: push access_ok() L1 attribute down, Linux Kernel Mailing ..., (Fri Jun 12, 2:00 pm)