ALSA: pcm - Fix update of runtime->hw_ptr_interrupt

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Friday, June 12, 2009 - 12:04 pm

Gitweb:     http://git.kernel.org/linus/ab1863fc9bc18c806338564124b1e5e7e3ef53d1
Commit:     ab1863fc9bc18c806338564124b1e5e7e3ef53d1
Parent:     d86bf92313bfd47885a92c7de63bde392d585f95
Author:     Takashi Iwai <tiwai@suse.de>
AuthorDate: Sun Jun 7 12:09:17 2009 +0200
Committer:  Takashi Iwai <tiwai@suse.de>
CommitDate: Sun Jun 7 12:19:33 2009 +0200

    ALSA: pcm - Fix update of runtime->hw_ptr_interrupt
    
    The commit 13f040f9e55d41e92e485389123654971e03b819 made another
    regression, the missing update of runtime->hw_ptr_interrupt.
    Since this field is only checked in snd_pcmupdate__hw_ptr_interrupt(),
    not in snd_pcm_update_hw_ptr(), it must be updated before the hw_ptr
    change check.
    
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/core/pcm_lib.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
index bf34603..adb306f 100644
--- a/sound/core/pcm_lib.c
+++ b/sound/core/pcm_lib.c
@@ -299,6 +299,8 @@ static int snd_pcm_update_hw_ptr_interrupt(struct snd_pcm_substream *substream)
 		hw_ptr_interrupt =
 			new_hw_ptr - new_hw_ptr % runtime->period_size;
 	}
+	runtime->hw_ptr_interrupt = hw_ptr_interrupt;
+
 	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK &&
 	    runtime->silence_size > 0)
 		snd_pcm_playback_silence(substream, new_hw_ptr);
@@ -309,7 +311,6 @@ static int snd_pcm_update_hw_ptr_interrupt(struct snd_pcm_substream *substream)
 	runtime->hw_ptr_base = hw_base;
 	runtime->status->hw_ptr = new_hw_ptr;
 	runtime->hw_ptr_jiffies = jiffies;
-	runtime->hw_ptr_interrupt = hw_ptr_interrupt;
 	if (runtime->tstamp_mode == SNDRV_PCM_TSTAMP_ENABLE)
 		snd_pcm_gettime(runtime, (struct timespec *)&runtime->status->tstamp);
 
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
ALSA: pcm - Fix update of runtime->hw_ptr_interrupt, Linux Kernel Mailing ..., (Fri Jun 12, 12:04 pm)