Gitweb:     http://git.kernel.org/linus/d6dcdea726855d78048e4bfb950342afc0e83e47
Commit:     d6dcdea726855d78048e4bfb950342afc0e83e47
Parent:     f9952beeaa851f7f79a4dd895bfed3f3ff6deebc
Author:     Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
AuthorDate: Sun Jun 7 15:37:07 2009 +0200
Committer:  Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
CommitDate: Sun Jun 7 15:37:07 2009 +0200

    ide: remove superfluous SELECT_MASK() call from do_rw_taskfile()
    
    With ->write_devctl method call (which unmasks drive IRQ) preceding
    SELECT_MASK() call there is really no need for the latter.
    
    Moreover with the combination of HPT36x controller and the drive on
    the quirk_drives[] list this can result in superfluous enable_irq()
    call which in turn will trigger WARN() in __enable_irq().
    
    Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
    Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/ide-taskfile.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/ide/ide-taskfile.c b/drivers/ide/ide-taskfile.c
index 8cab3c2..fbcb415 100644
--- a/drivers/ide/ide-taskfile.c
+++ b/drivers/ide/ide-taskfile.c
@@ -98,7 +98,6 @@ ide_startstop_t do_rw_taskfile(ide_drive_t *drive, struct ide_cmd *orig_cmd)
 	if ((cmd->tf_flags & IDE_TFLAG_DMA_PIO_FALLBACK) == 0) {
 		ide_tf_dump(drive->name, cmd);
 		tp_ops->write_devctl(hwif, ATA_DEVCTL_OBS);
-		SELECT_MASK(drive, 0);
 
 		if (cmd->ftf_flags & IDE_FTFLAG_OUT_DATA) {
 			u8 data[2] = { cmd->tf.data, cmd->hob.data };
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html