nilfs2: remove meaningless EBUSY case from nilfs_get_sb function

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Thursday, June 11, 2009 - 9:00 pm

Gitweb:     http://git.kernel.org/linus/81fc20bd0e75ba6357bce2403767d7c2585d8f28
Commit:     81fc20bd0e75ba6357bce2403767d7c2585d8f28
Parent:     0c95ee190e1dea60c55c834d14695341085c9b7b
Author:     Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
AuthorDate: Mon Jun 8 01:39:28 2009 +0900
Committer:  Al Viro <viro@zeniv.linux.org.uk>
CommitDate: Thu Jun 11 21:36:17 2009 -0400

    nilfs2: remove meaningless EBUSY case from nilfs_get_sb function
    
    The following EBUSY case in nilfs_get_sb() is meaningless.  Indeed,
    this error code is never returned to the caller.
    
        if (!s->s_root) {
              ...
        } else if (!(s->s_flags & MS_RDONLY)) {
            err = -EBUSY;
        }
    
    This simply removes the else case.
    
    Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 fs/nilfs2/super.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c
index 122dc1e..1c505d0 100644
--- a/fs/nilfs2/super.c
+++ b/fs/nilfs2/super.c
@@ -1186,8 +1186,6 @@ nilfs_get_sb(struct file_system_type *fs_type, int flags,
 
 		s->s_flags |= MS_ACTIVE;
 		need_to_close = 0;
-	} else if (!(s->s_flags & MS_RDONLY)) {
-		err = -EBUSY;
 	}
 
 	up(&sd.bdev->bd_mount_sem);
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
nilfs2: remove meaningless EBUSY case from nilfs_get_sb fu ..., Linux Kernel Mailing ..., (Thu Jun 11, 9:00 pm)