Input: tsc2007 - use disable_irq_nosync() in irq handler

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Saturday, May 2, 2009 - 5:00 pm

Gitweb:     http://git.kernel.org/linus/29fa98bd9b50b5e9c17d99e961640ffafb765d71
Commit:     29fa98bd9b50b5e9c17d99e961640ffafb765d71
Parent:     e4bd3e591c8cc52ccf7a0b27f33aa7a5a19058d7
Author:     Ben Nizette <bn@niasdigital.com>
AuthorDate: Fri Apr 17 20:35:57 2009 -0700
Committer:  Dmitry Torokhov <dmitry.torokhov@gmail.com>
CommitDate: Fri Apr 17 20:42:00 2009 -0700

    Input: tsc2007 - use disable_irq_nosync() in irq handler
    
    disable_irq() waits for all running handlers to complete before
    returning.  As such, if it's used to disable an interrupt from
    that interrupt's handler it will deadlock.  This replaces the
    dangerous instances with the _nosync() variant which doesn't have
    this problem.
    
    Signed-off-by: Ben Nizette <bn@niasdigital.com>
    Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---
 drivers/input/touchscreen/tsc2007.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/input/touchscreen/tsc2007.c b/drivers/input/touchscreen/tsc2007.c
index 4ab0702..536668f 100644
--- a/drivers/input/touchscreen/tsc2007.c
+++ b/drivers/input/touchscreen/tsc2007.c
@@ -235,7 +235,7 @@ static irqreturn_t tsc2007_irq(int irq, void *handle)
 	spin_lock_irqsave(&ts->lock, flags);
 
 	if (likely(ts->get_pendown_state())) {
-		disable_irq(ts->irq);
+		disable_irq_nosync(ts->irq);
 		hrtimer_start(&ts->timer, ktime_set(0, TS_POLL_DELAY),
 					HRTIMER_MODE_REL);
 	}
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Input: tsc2007 - use disable_irq_nosync() in irq handler, Linux Kernel Mailing ..., (Sat May 2, 5:00 pm)