Gitweb:     http://git.kernel.org/linus/99e3a1eb3c22bb671c6f3d22d8244bfc9fad8185
Commit:     99e3a1eb3c22bb671c6f3d22d8244bfc9fad8185
Parent:     64e3da109404eed27f825ee3eb1fe465ded47979
Author:     Cedric Hombourger <chombourger@gmail.com>
AuthorDate: Sat Apr 25 09:38:21 2009 +0200
Committer:  Sam Ravnborg <sam@ravnborg.org>
CommitDate: Fri May 1 10:54:03 2009 +0200

    kbuild: fix Module.markers permission error under cygwin
    
    While building the kernel, we end-up calling modpost with -K and -M
    options for the same file (Modules.markers).  This is resulting in
    modpost's main function calling read_markers() and then write_markers() on
    the same file.
    
    We then have read_markers() mmap'ing the file, and writer_markers()
    opening that same file for writing.
    
    The issue is that read_markers() exits without munmap'ing the file and is
    as a matter holding a reference on Modules.markers.  When write_markers()
    is opening that very same file for writing, we still have a reference on
    it and cygwin (Windows?) is then making fopen() fail with EPERM.
    
    Calling release_file() before exiting read_markers() clears that reference
    (and memory leak) and fopen() then succeeds.
    
    Tested on both cygwin (1.3.22) and Linux.  Also ran modpost within
    valgrind on Linux to make sure that the munmap'ed file was not accessed
    after read_markers()
    
    Signed-off-by: Cedric Hombourger <chombourger@gmail.com>
    Cc: <stable@kernel.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 scripts/mod/modpost.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 8d46ea7..57d71a5 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1990,6 +1990,7 @@ static void read_markers(const char *fname)
 		if (!mod->skip)
 			add_marker(mod, marker, fmt);
 	}
+	release_file(file, size);
 	return;
 fail:
 	fatal("parse error in markers list file\n");
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html