Doc: Fix wrong API example usage of call_rcu().

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Friday, April 3, 2009 - 11:03 am

Gitweb:     http://git.kernel.org/linus/3943ac5d99ec024f97442e5f3def1034bb0b1bb0
Commit:     3943ac5d99ec024f97442e5f3def1034bb0b1bb0
Parent:     9ba30d74446dd0629d797ecd038379725d351bc6
Author:     Jesper Dangaard Brouer <hawk@comx.dk>
AuthorDate: Sun Mar 29 23:03:01 2009 +0000
Committer:  David S. Miller <davem@davemloft.net>
CommitDate: Thu Apr 2 01:33:50 2009 -0700

    Doc: Fix wrong API example usage of call_rcu().
    
    At some point the API of call_rcu() changed from three parameters
    to two parameters, correct the documentation.
    
    One confusing thing in RCU/listRCU.txt, which is NOT fixed in this patch,
    is that no reason or explaination is given for using call_rcu() instead of
    the normal synchronize_rcu() call.
    
    Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    
    Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
    Signed-off-by: David S. Miller <davem@davemloft.net>
---
 Documentation/RCU/listRCU.txt |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/RCU/listRCU.txt b/Documentation/RCU/listRCU.txt
index 1fd1753..4349c14 100644
--- a/Documentation/RCU/listRCU.txt
+++ b/Documentation/RCU/listRCU.txt
@@ -118,7 +118,7 @@ Following are the RCU equivalents for these two functions:
 		list_for_each_entry(e, list, list) {
 			if (!audit_compare_rule(rule, &e->rule)) {
 				list_del_rcu(&e->list);
-				call_rcu(&e->rcu, audit_free_rule, e);
+				call_rcu(&e->rcu, audit_free_rule);
 				return 0;
 			}
 		}
@@ -206,7 +206,7 @@ RCU ("read-copy update") its name.  The RCU code is as follows:
 				ne->rule.action = newaction;
 				ne->rule.file_count = newfield_count;
 				list_replace_rcu(e, ne);
-				call_rcu(&e->rcu, audit_free_rule, e);
+				call_rcu(&e->rcu, audit_free_rule);
 				return 0;
 			}
 		}
@@ -283,7 +283,7 @@ flag under the spinlock as follows:
 				list_del_rcu(&e->list);
 				e->deleted = 1;
 				spin_unlock(&e->lock);
-				call_rcu(&e->rcu, audit_free_rule, e);
+				call_rcu(&e->rcu, audit_free_rule);
 				return 0;
 			}
 		}
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Doc: Fix wrong API example usage of call_rcu()., Linux Kernel Mailing ..., (Fri Apr 3, 11:03 am)