core: remove pointless conditional before kfree()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Thursday, April 2, 2009 - 10:05 pm

Gitweb:     http://git.kernel.org/linus/c9caceca25854eff4328c89045793a91bf8f9ee3
Commit:     c9caceca25854eff4328c89045793a91bf8f9ee3
Parent:     bb1fee86fdc7df1fd145fd3bfb16635274b7c73d
Author:     Wei Yongjun <yjwei@cn.fujitsu.com>
AuthorDate: Tue Mar 31 15:06:26 2009 -0700
Committer:  David S. Miller <davem@davemloft.net>
CommitDate: Tue Mar 31 15:06:26 2009 -0700

    core: remove pointless conditional before kfree()
    
    Remove pointless conditional before kfree().
    
    Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
---
 net/core/ethtool.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index 244ca56..d9d5160 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -261,8 +261,7 @@ static int ethtool_get_rxnfc(struct net_device *dev, void __user *useraddr)
 	ret = 0;
 
 err_out:
-	if (rule_buf)
-		kfree(rule_buf);
+	kfree(rule_buf);
 
 	return ret;
 }
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
core: remove pointless conditional before kfree(), Linux Kernel Mailing ..., (Thu Apr 2, 10:05 pm)