No need for crossing to mountpoint in audit_tag_tree()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Tuesday, April 21, 2009 - 2:59 pm

Gitweb:     http://git.kernel.org/linus/24b6f16ecf37f918a1934d590e9e71c100d6388f
Commit:     24b6f16ecf37f918a1934d590e9e71c100d6388f
Parent:     1644ccc8a99ae73859c39372f96afdbf03c9f80d
Author:     Al Viro <viro@zeniv.linux.org.uk>
AuthorDate: Sat Apr 18 03:25:41 2009 -0400
Committer:  Al Viro <viro@zeniv.linux.org.uk>
CommitDate: Mon Apr 20 23:01:15 2009 -0400

    No need for crossing to mountpoint in audit_tag_tree()
    
    is_under() will DTRT anyway.  And yes, is_subdir() behaviour
    is intentional.
    
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 fs/dcache.c         |    1 -
 kernel/audit_tree.c |    3 ---
 2 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/fs/dcache.c b/fs/dcache.c
index 761d30b..1fcffeb 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -2149,7 +2149,6 @@ int is_subdir(struct dentry *new_dentry, struct dentry *old_dentry)
 	int result;
 	unsigned long seq;
 
-	/* FIXME: This is old behavior, needed? Please check callers. */
 	if (new_dentry == old_dentry)
 		return 1;
 
diff --git a/kernel/audit_tree.c b/kernel/audit_tree.c
index 917ab95..6e73517 100644
--- a/kernel/audit_tree.c
+++ b/kernel/audit_tree.c
@@ -734,9 +734,6 @@ int audit_tag_tree(char *old, char *new)
 	dentry = dget(path.dentry);
 	path_put(&path);
 
-	if (dentry == tagged->mnt_root && dentry == mnt->mnt_root)
-		follow_up(&mnt, &dentry);
-
 	list_add_tail(&list, &tagged->mnt_list);
 
 	mutex_lock(&audit_filter_mutex);
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
No need for crossing to mountpoint in audit_tag_tree(), Linux Kernel Mailing ..., (Tue Apr 21, 2:59 pm)