netxen: fix physical port mapping

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Monday, March 2, 2009 - 5:00 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=044fad...
Commit:     044fad0dbb4e814c061916fe5a36851af2fd1135
Parent:     50fee1dec5d71b8a14c1b82f2f42e16adc227f8b
Author:     Dhananjay Phadke <dhananjay@netxen.com>
AuthorDate: Tue Feb 24 03:42:59 2009 -0800
Committer:  David S. Miller <davem@davemloft.net>
CommitDate: Tue Feb 24 03:42:59 2009 -0800

    netxen: fix physical port mapping
    
    The PCI function to physical port mapping is valid only for
    old firmware. New firmware (4.0.0+) abstracts this.
    So driver should never try to access phy using invalid
    mapping. The behavior is unpredictable when PCI functions
    4-7 are enabled on the same NIC.
    
    Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/netxen/netxen_nic_main.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index 9f33e44..f425811 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -795,9 +795,12 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	 * See if the firmware gave us a virtual-physical port mapping.
 	 */
 	adapter->physical_port = adapter->portnum;
-	i = adapter->pci_read_normalize(adapter, CRB_V2P(adapter->portnum));
-	if (i != 0x55555555)
-		adapter->physical_port = i;
+	if (adapter->fw_major < 4) {
+		i = adapter->pci_read_normalize(adapter,
+				CRB_V2P(adapter->portnum));
+		if (i != 0x55555555)
+			adapter->physical_port = i;
+	}
 
 	adapter->flags &= ~(NETXEN_NIC_MSI_ENABLED | NETXEN_NIC_MSIX_ENABLED);
 
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
netxen: fix physical port mapping, Linux Kernel Mailing ..., (Mon Mar 2, 5:00 pm)