pata-rb532-cf: use ata_sff_exec_command()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Thursday, March 26, 2009 - 12:31 pm

Gitweb:     http://git.kernel.org/linus/bff9ad3c4c8fff340854d3912196ed470f94602c
Commit:     bff9ad3c4c8fff340854d3912196ed470f94602c
Parent:     96b34ce7cafa0888580698d199b9fac6ad9f9a2e
Author:     Phil Sutter <n0-1@freewrt.org>
AuthorDate: Tue Jan 27 14:35:51 2009 +0100
Committer:  Jeff Garzik <jgarzik@redhat.com>
CommitDate: Tue Mar 24 22:02:39 2009 -0400

    pata-rb532-cf: use ata_sff_exec_command()
    
    The only difference between rb532_pata_exec_command() and
    ata_sff_exec_command() is added debugging output, so it can be dropped
    and the standard op used instead.
    
    Signed-off-by: Phil Sutter <n0-1@freewrt.org>
    Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
 drivers/ata/pata_rb532_cf.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/drivers/ata/pata_rb532_cf.c b/drivers/ata/pata_rb532_cf.c
index 6fe660b..9d61ce5 100644
--- a/drivers/ata/pata_rb532_cf.c
+++ b/drivers/ata/pata_rb532_cf.c
@@ -54,13 +54,6 @@ struct rb532_cf_info {
 
 /* ------------------------------------------------------------------------ */
 
-static void rb532_pata_exec_command(struct ata_port *ap,
-				const struct ata_taskfile *tf)
-{
-	writeb(tf->command, ap->ioaddr.command_addr);
-	ata_sff_pause(ap);
-}
-
 static unsigned int rb532_pata_data_xfer(struct ata_device *adev, unsigned char *buf,
 				unsigned int buflen, int write_data)
 {
@@ -112,7 +105,6 @@ static irqreturn_t rb532_pata_irq_handler(int irq, void *dev_instance)
 
 static struct ata_port_operations rb532_pata_port_ops = {
 	.inherits		= &ata_sff_port_ops,
-	.sff_exec_command	= rb532_pata_exec_command,
 	.sff_data_xfer		= rb532_pata_data_xfer,
 	.freeze			= rb532_pata_freeze,
 	.thaw			= rb532_pata_thaw,
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
pata-rb532-cf: use ata_sff_exec_command(), Linux Kernel Mailing ..., (Thu Mar 26, 12:31 pm)