pata-rb532-cf: replace rb532_pata_finish_io()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Thursday, March 26, 2009 - 12:31 pm

Gitweb:     http://git.kernel.org/linus/96b34ce7cafa0888580698d199b9fac6ad9f9a2e
Commit:     96b34ce7cafa0888580698d199b9fac6ad9f9a2e
Parent:     84bcbeebcfd283c3f4804287ed4610c3a18e1590
Author:     Phil Sutter <n0-1@freewrt.org>
AuthorDate: Tue Jan 27 14:35:50 2009 +0100
Committer:  Jeff Garzik <jgarzik@redhat.com>
CommitDate: Tue Mar 24 22:02:39 2009 -0400

    pata-rb532-cf: replace rb532_pata_finish_io()
    
    Since the delay used internally is just the same as ata_sff_pause()
    uses, rb532_pata_finish_io() does exactly the same as ata_sff_pause()
    and thus can be replaced by the later one.
    
    Signed-off-by: Phil Sutter <n0-1@freewrt.org>
    Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
 drivers/ata/pata_rb532_cf.c |   15 ++-------------
 1 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/drivers/ata/pata_rb532_cf.c b/drivers/ata/pata_rb532_cf.c
index ebfcda2..6fe660b 100644
--- a/drivers/ata/pata_rb532_cf.c
+++ b/drivers/ata/pata_rb532_cf.c
@@ -54,22 +54,11 @@ struct rb532_cf_info {
 
 /* ------------------------------------------------------------------------ */
 
-static inline void rb532_pata_finish_io(struct ata_port *ap)
-{
-	struct ata_host *ah = ap->host;
-	struct rb532_cf_info *info = ah->private_data;
-
-	/* FIXME: Keep previous delay. If this is merely a fence then
-	   ata_sff_sync might be sufficient. */
-	ata_sff_dma_pause(ap);
-	ndelay(RB500_CF_IO_DELAY);
-}
-
 static void rb532_pata_exec_command(struct ata_port *ap,
 				const struct ata_taskfile *tf)
 {
 	writeb(tf->command, ap->ioaddr.command_addr);
-	rb532_pata_finish_io(ap);
+	ata_sff_pause(ap);
 }
 
 static unsigned int rb532_pata_data_xfer(struct ata_device *adev, unsigned char *buf,
@@ -87,7 +76,7 @@ static unsigned int rb532_pata_data_xfer(struct ata_device *adev, unsigned char
 			*buf = readb(ioaddr);
 	}
 
-	rb532_pata_finish_io(adev->link->ap);
+	ata_sff_pause(ap);
 	return retlen;
 }
 
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
pata-rb532-cf: replace rb532_pata_finish_io(), Linux Kernel Mailing ..., (Thu Mar 26, 12:31 pm)