ext4: Print the find_group_flex() warning only once

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Wednesday, March 18, 2009 - 9:59 am

Gitweb:     http://git.kernel.org/linus/2842c3b5449f31470b61db716f1926b594fb6156
Commit:     2842c3b5449f31470b61db716f1926b594fb6156
Parent:     395a87bfefbc400011417e9eaae33169f9f036c0
Author:     Theodore Ts'o <tytso@mit.edu>
AuthorDate: Thu Mar 12 12:20:01 2009 -0400
Committer:  Theodore Ts'o <tytso@mit.edu>
CommitDate: Thu Mar 12 12:20:01 2009 -0400

    ext4: Print the find_group_flex() warning only once
    
    This is a short-term warning, and even printk_ratelimit() can result
    in too much noise in system logs.  So only print it once as a warning.
    
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 fs/ext4/ialloc.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index 627f8c3..2d2b358 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -698,6 +698,7 @@ struct inode *ext4_new_inode(handle_t *handle, struct inode *dir, int mode)
 	struct inode *ret;
 	ext4_group_t i;
 	int free = 0;
+	static int once = 1;
 	ext4_group_t flex_group;
 
 	/* Cannot create files in a deleted directory */
@@ -719,7 +720,8 @@ struct inode *ext4_new_inode(handle_t *handle, struct inode *dir, int mode)
 		ret2 = find_group_flex(sb, dir, &group);
 		if (ret2 == -1) {
 			ret2 = find_group_other(sb, dir, &group);
-			if (ret2 == 0 && printk_ratelimit())
+			if (ret2 == 0 && once)
+				once = 0;
 				printk(KERN_NOTICE "ext4: find_group_flex "
 				       "failed, fallback succeeded dir %lu\n",
 				       dir->i_ino);
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
ext4: Print the find_group_flex() warning only once, Linux Kernel Mailing ..., (Wed Mar 18, 9:59 am)