sparc64: fix modpost failure

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Monday, January 26, 2009 - 4:59 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=62dfcd...
Commit:     62dfcd336c79c49f9aeb0acc99cf9a1832102dd5
Parent:     c275ce44929402664902cbb09d4f054b315623d7
Author:     Sam Ravnborg <sam@ravnborg.org>
AuthorDate: Sat Jan 17 23:12:27 2009 -0800
Committer:  David S. Miller <davem@davemloft.net>
CommitDate: Sat Jan 17 23:12:27 2009 -0800

    sparc64: fix modpost failure
    
    Previously PeeCeeI.o was a library but it
    was always pulled in due to insw and friends being exported
    (at least for a modular kernel).
    
    But this resulted in modpost failures if there where no in-kernel
    users because then insw & friends were not linked in.
    
    Fix this by including PeeCeeI.o in the kernel unconditionally.
    
    The only drawback for this solution is that a nonmodular kernel
    will always include insw & friends no matter if they are in use or not.
    
    Reported-by: Meelis Roos <mroos@linux.ee>
    Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
---
 arch/sparc/lib/Makefile |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/sparc/lib/Makefile b/arch/sparc/lib/Makefile
index 273fc85..e75faf0 100644
--- a/arch/sparc/lib/Makefile
+++ b/arch/sparc/lib/Makefile
@@ -18,7 +18,7 @@ lib-$(CONFIG_SPARC32) += lshrdi3.o ashldi3.o
 lib-y                 += rwsem_$(BITS).o
 lib-$(CONFIG_SPARC32) += muldi3.o bitext.o cmpdi2.o
 
-lib-$(CONFIG_SPARC64) += PeeCeeI.o copy_page.o clear_page.o bzero.o
+lib-$(CONFIG_SPARC64) += copy_page.o clear_page.o bzero.o
 lib-$(CONFIG_SPARC64) += csum_copy.o csum_copy_from_user.o csum_copy_to_user.o
 lib-$(CONFIG_SPARC64) += VISsave.o
 lib-$(CONFIG_SPARC64) += bitops.o
@@ -43,3 +43,4 @@ lib-$(CONFIG_SPARC64) += mcount.o ipcsum.o xor.o
 obj-y                 += iomap.o
 obj-$(CONFIG_SPARC32) += atomic32.o
 obj-y                 += ksyms.o
+obj-$(CONFIG_SPARC64) += PeeCeeI.o
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
sparc64: fix modpost failure, Linux Kernel Mailing ..., (Mon Jan 26, 4:59 pm)