drivers/char/cyclades.c: cy_pci_probe: fix error path

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Friday, January 2, 2009 - 1:02 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c847d4...
Commit:     c847d47cb7b2fa78b17c9e17ed3fbd010ee3d3ca
Parent:     6b06f19151c335ee0c5b61839fa4e6838182ebb8
Author:     Andrew Morton <akpm@linux-foundation.org>
AuthorDate: Fri Jan 2 13:50:07 2009 +0000
Committer:  Linus Torvalds <torvalds@linux-foundation.org>
CommitDate: Fri Jan 2 10:19:43 2009 -0800

    drivers/char/cyclades.c: cy_pci_probe: fix error path
    
    We forgot to release resources in one case.
    
    Addresses http://bugzilla.kernel.org/show_bug.cgi?id=12137
    
    Reported-by: Florian Lohoff <flo@rfc822.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Alan Cox <alan@redhat.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---
 drivers/char/cyclades.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/cyclades.c b/drivers/char/cyclades.c
index 5e5b1dc..6a59f72 100644
--- a/drivers/char/cyclades.c
+++ b/drivers/char/cyclades.c
@@ -5010,7 +5010,7 @@ static int __devinit cy_pci_probe(struct pci_dev *pdev,
 		if (nchan == 0) {
 			dev_err(&pdev->dev, "Cyclom-Y PCI host card with no "
 					"Serial-Modules\n");
-			return -EIO;
+			goto err_unmap;
 		}
 	} else if (device_id == PCI_DEVICE_ID_CYCLOM_Z_Hi) {
 		struct RUNTIME_9060 __iomem *ctl_addr;
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
drivers/char/cyclades.c: cy_pci_probe: fix error path, Linux Kernel Mailing ..., (Fri Jan 2, 1:02 pm)