korina: fix usage of driver_data

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Thursday, January 15, 2009 - 7:05 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b96ecf...
Commit:     b96ecfa689126d1e652ebd758da0b5b9b27dbd12
Parent:     0ef00459a638ae4f5d1e5326d3e50232fa80119f
Author:     Phil Sutter <n0-1@freewrt.org>
AuthorDate: Wed Jan 14 21:46:51 2009 -0800
Committer:  David S. Miller <davem@davemloft.net>
CommitDate: Thu Jan 15 08:28:17 2009 -0800

    korina: fix usage of driver_data
    
    Using platform_set_drvdata() here makes no sense, since the driver_data
    field has already been filled with valuable data (i.e. the MAC address).
    Also having driver_data point to the net_device is rather pointless
    since struct korina_device contains an apropriate field for it.
    
    Signed-off-by: Phil Sutter <n0-1@freewrt.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/korina.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/korina.c b/drivers/net/korina.c
index 4a5580c..fefb33d 100644
--- a/drivers/net/korina.c
+++ b/drivers/net/korina.c
@@ -1089,7 +1089,6 @@ static int korina_probe(struct platform_device *pdev)
 		return -ENOMEM;
 	}
 	SET_NETDEV_DEV(dev, &pdev->dev);
-	platform_set_drvdata(pdev, dev);
 	lp = netdev_priv(dev);
 
 	bif->dev = dev;
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
korina: fix usage of driver_data, Linux Kernel Mailing ..., (Thu Jan 15, 7:05 pm)