ftdi_sio: fix kref leak

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Thursday, January 15, 2009 - 6:59 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=a9fec7...
Commit:     a9fec7102f01f6464b19e13ffd9d8c48663379ad
Parent:     cd1e40f0981e22018373307cd4087dc876b08fb0
Author:     Jim Paris <jim@jtan.com>
AuthorDate: Thu Jan 15 13:31:07 2009 +0000
Committer:  Linus Torvalds <torvalds@linux-foundation.org>
CommitDate: Thu Jan 15 12:48:36 2009 -0800

    ftdi_sio: fix kref leak
    
    Commit 4a90f09b20f4622dcbff1f0e1e6bae1704f8ad8c added kref stuff to
    ftdi_sio, but missed tty_kref_put at one exit point in
    ftdi_process_read.
    
    Signed-off-by: Jim Paris <jim@jtan.com>
    Signed-off-by: Alan Cox <alan@redhat.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---
 drivers/usb/serial/ftdi_sio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index ef6cfa5..c70a8f6 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -2030,7 +2030,7 @@ static void ftdi_process_read(struct work_struct *work)
 			spin_unlock_irqrestore(&priv->rx_lock, flags);
 			dbg("%s - deferring remainder until unthrottled",
 					__func__);
-			return;
+			goto out;
 		}
 		spin_unlock_irqrestore(&priv->rx_lock, flags);
 		/* if the port is closed stop trying to read */
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
ftdi_sio: fix kref leak, Linux Kernel Mailing ..., (Thu Jan 15, 6:59 pm)