hwmon-vid: Fix AMD K8 VID decoding

Previous thread: x86: add MAP_STACK mmap flag by Linux Kernel Mailing List on Friday, August 15, 2008 - 12:01 pm. (1 message)

Next thread: ALSA: virtuoso: add Xonar D1 support by Linux Kernel Mailing List on Friday, August 15, 2008 - 12:01 pm. (1 message)
From: Linux Kernel Mailing List
Date: Friday, August 15, 2008 - 12:01 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=cebd77...
Commit:     cebd7709d396b59ff53b95fa3c4d9febbd4c010f
Parent:     cd98a04a59e2f94fa64d5bf1e26498d27427d5e7
Author:     Jean Delvare <khali@linux-fr.org>
AuthorDate: Fri Aug 15 10:58:05 2008 +0200
Committer:  Linus Torvalds <torvalds@linux-foundation.org>
CommitDate: Fri Aug 15 11:50:15 2008 -0700

    hwmon-vid: Fix AMD K8 VID decoding
    
    Not all AMD K8 have 6 VID pins, contrary to what was assumed in
    commit 116d0486bdefc11f71e567cadf0c47f788b4dd06. This commit broke
    support of older CPU models which have only 5 VID pins:
    http://bugzilla.kernel.org/show_bug.cgi?id=11329
    
    We need two entries in the hwmon-vid table, one for 5-bit VID models
    (K8 revision <= E) and one for 6-bit VID models (K8 revision >= F).
    This fixes bug #11329.
    
    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Acked-by: Frank Myhr <fmyhr@fhmtech.com>
    Tested-by: Jean-Luc Coulon <jean.luc.coulon@gmail.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---
 drivers/hwmon/hwmon-vid.c |   36 ++++++++++++++++++++++++++++--------
 1 files changed, 28 insertions(+), 8 deletions(-)

diff --git a/drivers/hwmon/hwmon-vid.c b/drivers/hwmon/hwmon-vid.c
index 7b0a32c..c54eff9 100644
--- a/drivers/hwmon/hwmon-vid.c
+++ b/drivers/hwmon/hwmon-vid.c
@@ -37,13 +37,21 @@
  * For VRD 10.0 and up, "VRD x.y Design Guide",
  * available at http://developer.intel.com/.
  *
- * AMD NPT 0Fh (Athlon64 & Opteron), AMD Publication 32559,
+ * AMD Athlon 64 and AMD Opteron Processors, AMD Publication 26094,
+ * http://www.amd.com/us-en/assets/content_type/white_papers_and_tech_docs/26094.PDF
+ * Table 74. VID Code Voltages
+ * This corresponds to an arbitrary VRM code of 24 in the functions below.
+ * These CPU models (K8 revision <= E) have 5 VID pins. See also:
+ * Revision Guide for AMD Athlon 64 and AMD Opteron Processors, AMD ...
Previous thread: x86: add MAP_STACK mmap flag by Linux Kernel Mailing List on Friday, August 15, 2008 - 12:01 pm. (1 message)

Next thread: ALSA: virtuoso: add Xonar D1 support by Linux Kernel Mailing List on Friday, August 15, 2008 - 12:01 pm. (1 message)