[CIFS] mount of IPC$ breaks with iget patch

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Friday, August 15, 2008 - 12:01 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=ad6613...
Commit:     ad661334b8ae421154b121ee6ad3b56807adbf11
Parent:     54b4602d5fe50571362e101138d24edb9cf82d29
Author:     Steve French <sfrench@us.ibm.com>
AuthorDate: Tue Aug 12 14:14:40 2008 +0000
Committer:  Steve French <sfrench@us.ibm.com>
CommitDate: Thu Aug 14 03:55:14 2008 +0000

    [CIFS] mount of IPC$ breaks with iget patch
    
    In looking at network named pipe support on cifs, I noticed that
    Dave Howell's iget patch:
    
        iget: stop CIFS from using iget() and read_inode()
    
    broke mounts to IPC$ (the interprocess communication share), and don't
    handle the error case (when getting info on the root inode fails).
    
    Thanks to Gunter who noted a typo in a debug line in the original
    version of this patch.
    
    CC: David Howells <dhowells@redhat.com>
    CC: Gunter Kukkukk <linux@kukkukk.com>
    CC: Stable Kernel <stable@kernel.org>
    Signed-off-by: Steve French <sfrench@us.ibm.com>
---
 fs/cifs/inode.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index 28a2209..8482868 100644
--- a/fs/cifs/inode.c
+++ b/fs/cifs/inode.c
@@ -649,6 +649,7 @@ struct inode *cifs_iget(struct super_block *sb, unsigned long ino)
 		inode->i_fop = &simple_dir_operations;
 		inode->i_uid = cifs_sb->mnt_uid;
 		inode->i_gid = cifs_sb->mnt_gid;
+	} else if (rc) {
 		_FreeXid(xid);
 		iget_failed(inode);
 		return ERR_PTR(rc);
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[CIFS] mount of IPC$ breaks with iget patch, Linux Kernel Mailing ..., (Fri Aug 15, 12:01 pm)