sh_keysc: remove request_mem_region() and release_mem_region()

Previous thread: sh: Don't miss pending signals returning to user mode after signal processing by Linux Kernel Mailing List on Monday, July 28, 2008 - 10:09 am. (1 message)

Next thread: sh: fix uImage Entry Point by Linux Kernel Mailing List on Monday, July 28, 2008 - 10:09 am. (1 message)
From: Linux Kernel Mailing List
Date: Monday, July 28, 2008 - 10:09 am

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d3aa43...
Commit:     d3aa43a9db3b18e65f91985b5b91f2450d8b4048
Parent:     0b1689cfbbc5e81a121f550782a201962c1e0ce0
Author:     Tetsuya Mukawa <mukawa@igel.co.jp>
AuthorDate: Sat Jul 19 07:46:53 2008 +0900
Committer:  Paul Mundt <lethal@linux-sh.org>
CommitDate: Mon Jul 28 18:10:37 2008 +0900

    sh_keysc: remove request_mem_region() and release_mem_region()
    
    Remove request_mem_region() and release_mem_region() from sh_keysc driver.
    Those functions can find resource conflict, but it is already checked in
    platform_device_add().
    
    Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
    Signed-off-by: Magnus Damm <damm@igel.co.jp>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Cc: Dmitry Torokhov <dtor@mail.ru>
    Signed-off-by: Paul Mundt <lethal@linux-sh.org>
---
 drivers/input/keyboard/sh_keysc.c |   27 +++++++--------------------
 1 files changed, 7 insertions(+), 20 deletions(-)

diff --git a/drivers/input/keyboard/sh_keysc.c b/drivers/input/keyboard/sh_keysc.c
index 8486abc..c600ab7 100644
--- a/drivers/input/keyboard/sh_keysc.c
+++ b/drivers/input/keyboard/sh_keysc.c
@@ -158,25 +158,18 @@ static int __devinit sh_keysc_probe(struct platform_device *pdev)
 	memcpy(&priv->pdata, pdev->dev.platform_data, sizeof(priv->pdata));
 	pdata = &priv->pdata;
 
-	res = request_mem_region(res->start, res_size(res), pdev->name);
-	if (res == NULL) {
-		dev_err(&pdev->dev, "failed to request I/O memory\n");
-		error = -EBUSY;
-		goto err1;
-	}
-
 	priv->iomem_base = ioremap_nocache(res->start, res_size(res));
 	if (priv->iomem_base == NULL) {
 		dev_err(&pdev->dev, "failed to remap I/O memory\n");
 		error = -ENXIO;
-		goto err2;
+		goto err1;
 	}
 
 	priv->input = input_allocate_device();
 	if (!priv->input) {
 		dev_err(&pdev->dev, "failed to allocate input device\n");
 		error = -ENOMEM;
-		goto ...
Previous thread: sh: Don't miss pending signals returning to user mode after signal processing by Linux Kernel Mailing List on Monday, July 28, 2008 - 10:09 am. (1 message)

Next thread: sh: fix uImage Entry Point by Linux Kernel Mailing List on Monday, July 28, 2008 - 10:09 am. (1 message)