Home » Mailing list archives » git-commits-head » 2008 » July » 28

V4L/DVB (8493): mt20xx: test below 0 on unsigned lo1a and lo2a

Previous thread: V4L/DVB (8492): Add support for the ATI TV Wonder HD 600 by Linux Kernel Mailing List on Monday, July 28, 2008 - 10:03 am. (1 message)

Next thread: V4L/DVB (8495): usb/anysee.c: make struct anysee_usb_mutex static by Linux Kernel Mailing List on Monday, July 28, 2008 - 10:03 am. (1 message)
[view original message]
From: Linux Kernel Mailing List
Subject: V4L/DVB (8493): mt20xx: test below 0 on unsigned lo1a and lo2a
Date: Monday, July 28, 2008 - 10:03 am

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1ffddd...
Commit:     1ffdddd6fa3d18982133f6d149d456312d8bfcac
Parent:     e14b3658a7651ffd9b1f407eaf07f4dde17ef1e7
Author:     roel kluin <roel.kluin@gmail.com>
AuthorDate: Mon Jul 21 21:29:46 2008 -0300
Committer:  Mauro Carvalho Chehab <mchehab@infradead.org>
CommitDate: Sat Jul 26 13:18:19 2008 -0300

    V4L/DVB (8493): mt20xx: test below 0 on unsigned lo1a and lo2a
    
    lo1a and lo2a are unsigned ints so these tests won't work.
    
    Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---
 drivers/media/common/tuners/mt20xx.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/media/common/tuners/mt20xx.c b/drivers/media/common/tuners/mt20xx.c
index fbcb282..35b763a 100644
--- a/drivers/media/common/tuners/mt20xx.c
+++ b/drivers/media/common/tuners/mt20xx.c
@@ -148,7 +148,8 @@ static int mt2032_compute_freq(struct dvb_frontend *fe,
 	tuner_dbg("mt2032: rfin=%d lo2=%d lo2n=%d lo2a=%d num=%d lo2freq=%d\n",
 		  rfin,lo2,lo2n,lo2a,lo2num,lo2freq);
 
-	if(lo1a<0 || lo1a>7 || lo1n<17 ||lo1n>48 || lo2a<0 ||lo2a >7 ||lo2n<17 || lo2n>30) {
+	if (lo1a > 7 || lo1n < 17 || lo1n > 48 || lo2a > 7 || lo2n < 17 ||
+			lo2n > 30) {
 		tuner_info("mt2032: frequency parameters out of range: %d %d %d %d\n",
 			   lo1a, lo1n, lo2a,lo2n);
 		return(-1);
--


[ message continues ]
Previous thread: V4L/DVB (8492): Add support for the ATI TV Wonder HD 600 by Linux Kernel Mailing List on Monday, July 28, 2008 - 10:03 am. (1 message)

Next thread: V4L/DVB (8495): usb/anysee.c: make struct anysee_usb_mutex static by Linux Kernel Mailing List on Monday, July 28, 2008 - 10:03 am. (1 message)