dccp: Fix sequence number check for ICMPv4 packets

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Monday, July 28, 2008 - 9:59 am

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d68f08...
Commit:     d68f0866f76e2bc4ddc07e88e2cb1bc8959a6d7e
Parent:     73f18fdbca3f92b90aeaee16f5175fe30496e218
Author:     Wei Yongjun <yjwei@cn.fujitsu.com>
AuthorDate: Sat Jul 26 11:59:10 2008 +0100
Committer:  Gerrit Renker <gerrit@erg.abdn.ac.uk>
CommitDate: Sat Jul 26 11:59:10 2008 +0100

    dccp: Fix sequence number check for ICMPv4 packets
    
    The payload of ICMP message is a part of the packet sent by ourself,
    so the sequence number check must use AWL and AWH, not SWL and SWH.
    
    For example:
         Endpoint A                  Endpoint B
    
         DATA-ACK       -------->
         (SEQ=X)
                        <--------    ICMP (Fragmentation Needed)
                                     (SEQ=X)
    
    Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
    Acked-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
---
 net/dccp/ipv4.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c
index a835b88..6a2f187 100644
--- a/net/dccp/ipv4.c
+++ b/net/dccp/ipv4.c
@@ -238,7 +238,7 @@ static void dccp_v4_err(struct sk_buff *skb, u32 info)
 	dp = dccp_sk(sk);
 	seq = dccp_hdr_seq(dh);
 	if ((1 << sk->sk_state) & ~(DCCPF_REQUESTING | DCCPF_LISTEN) &&
-	    !between48(seq, dp->dccps_swl, dp->dccps_swh)) {
+	    !between48(seq, dp->dccps_awl, dp->dccps_awh)) {
 		NET_INC_STATS_BH(net, LINUX_MIB_OUTOFWINDOWICMPS);
 		goto out;
 	}
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
dccp: Fix sequence number check for ICMPv4 packets, Linux Kernel Mailing ..., (Mon Jul 28, 9:59 am)