Home » Mailing list archives » git-commits-head » 2008 » July » 28

ipwireless: Increase PPP outgoing queue size

Previous thread: ipwireless: Explicitly request io and mem regions by Linux Kernel Mailing List on Monday, July 28, 2008 - 9:59 am. (1 message)

Next thread: ipwireless: Put packets to pool start by Linux Kernel Mailing List on Monday, July 28, 2008 - 9:59 am. (1 message)
[view original message]
From: Linux Kernel Mailing List
Subject: ipwireless: Increase PPP outgoing queue size
Date: Monday, July 28, 2008 - 9:59 am

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=bee9c7...
Commit:     bee9c7c0773517c9f1d7931144fc8dec12233bd7
Parent:     09e491e9a780433f8734eb6efb7293b2da690131
Author:     David Sterba <dsterba@suse.cz>
AuthorDate: Mon Jul 28 16:53:21 2008 +0200
Committer:  Linus Torvalds <torvalds@linux-foundation.org>
CommitDate: Mon Jul 28 08:28:03 2008 -0700

    ipwireless: Increase PPP outgoing queue size
    
    ipwireless: Increase PPP outgoing queue size
    
    Increase default size of PPP outgoing queue. Currently set to 1, which
    means that a packet quickly following another pushed by PPP must wait
    until hardware actually sends the previous and PPP has to be waken up
    by ppp_wakeup(). This slows down upstream.
    
    Now PPP can push more packets at once which get buffered inside driver
    and pushed immediatelly to hardware when previous packet is out.
    
    Experiments show that size = 10 is quite good for all connection types
    (GPRS/EDGE/UMTS) and gains 4 KB/sec of upload for UMTS for batch uploads.
    Need for higher queue size than 10 occures in only < 0.1 % of cases.
    
    Signed-off-by: David Sterba <dsterba@suse.cz>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---
 drivers/char/pcmcia/ipwireless/main.c    |    4 ++--
 drivers/char/pcmcia/ipwireless/network.c |    4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/char/pcmcia/ipwireless/main.c b/drivers/char/pcmcia/ipwireless/main.c
index 7169a0d..5eca7a9 100644
--- a/drivers/char/pcmcia/ipwireless/main.c
+++ b/drivers/char/pcmcia/ipwireless/main.c
@@ -49,7 +49,7 @@ static void ipwireless_detach(struct pcmcia_device *link);
 /* Debug mode: more verbose, print sent/recv bytes */
 int ipwireless_debug;
 int ipwireless_loopback;
-int ipwireless_out_queue = 1;
+int ipwireless_out_queue = 10;
 
 module_param_named(debug, ...
[ message continues ]
Previous thread: ipwireless: Explicitly request io and mem regions by Linux Kernel Mailing List on Monday, July 28, 2008 - 9:59 am. (1 message)

Next thread: ipwireless: Put packets to pool start by Linux Kernel Mailing List on Monday, July 28, 2008 - 9:59 am. (1 message)