Home » Mailing list archives » git-commits-head » 2008 » July » 28

ipwireless: Explicitly request io and mem regions

Previous thread: ipwireless: Constify buffer variables by Linux Kernel Mailing List on Monday, July 28, 2008 - 9:59 am. (1 message)

Next thread: ipwireless: Increase PPP outgoing queue size by Linux Kernel Mailing List on Monday, July 28, 2008 - 9:59 am. (1 message)
[view original message]
From: Linux Kernel Mailing List
Subject: ipwireless: Explicitly request io and mem regions
Date: Monday, July 28, 2008 - 9:59 am

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=09e491...
Commit:     09e491e9a780433f8734eb6efb7293b2da690131
Parent:     ff3e990e61a5a9124687a01a025c43b3564f82ab
Author:     David Sterba <dsterba@suse.cz>
AuthorDate: Mon Jul 28 16:53:16 2008 +0200
Committer:  Linus Torvalds <torvalds@linux-foundation.org>
CommitDate: Mon Jul 28 08:28:03 2008 -0700

    ipwireless: Explicitly request io and mem regions
    
    ipwireless: Explicitly request io and mem regions
    
    Documentation/pcmcia/driver-changes.txt says, that driver should call request_region
    for used memory/io regions since PCMCIA does not do this (since 2.6.8).
    
    Signed-off-by: David Sterba <dsterba@suse.cz>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---
 drivers/char/pcmcia/ipwireless/main.c |   79 +++++++++++++++++++--------------
 drivers/char/pcmcia/ipwireless/main.h |    5 ++
 2 files changed, 50 insertions(+), 34 deletions(-)

diff --git a/drivers/char/pcmcia/ipwireless/main.c b/drivers/char/pcmcia/ipwireless/main.c
index 6bdd11d..7169a0d 100644
--- a/drivers/char/pcmcia/ipwireless/main.c
+++ b/drivers/char/pcmcia/ipwireless/main.c
@@ -88,8 +88,6 @@ static int config_ipwireless(struct ipw_dev *ipw)
 	unsigned short buf[64];
 	cisparse_t parse;
 	unsigned short cor_value;
-	win_req_t request_attr_memory;
-	win_req_t request_common_memory;
 	memreq_t memreq_attr_memory;
 	memreq_t memreq_common_memory;
 
@@ -188,6 +186,9 @@ static int config_ipwireless(struct ipw_dev *ipw)
 		goto exit0;
 	}
 
+	request_region(link->io.BasePort1, link->io.NumPorts1,
+			IPWIRELESS_PCCARD_NAME);
+
 	/* memory settings */
 
 	tuple.DesiredTuple = CISTPL_CFTABLE_ENTRY;
@@ -214,16 +215,16 @@ static int config_ipwireless(struct ipw_dev *ipw)
 	}
 
 	if (parse.cftable_entry.mem.nwin > 0) {
-		request_common_memory.Attributes ...
[ message continues ]
Previous thread: ipwireless: Constify buffer variables by Linux Kernel Mailing List on Monday, July 28, 2008 - 9:59 am. (1 message)

Next thread: ipwireless: Increase PPP outgoing queue size by Linux Kernel Mailing List on Monday, July 28, 2008 - 9:59 am. (1 message)