kbuild: refactor headers_* targets in Makefile

Previous thread: crypto: talitos - sparse fix by Linux Kernel Mailing List on Sunday, July 27, 2008 - 11:00 am. (1 message)

Next thread: kbuild: always unifdef files in headers_install* by Linux Kernel Mailing List on Sunday, July 27, 2008 - 11:00 am. (1 message)
From: Linux Kernel Mailing List
Date: Sunday, July 27, 2008 - 11:00 am

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e6883b...
Commit:     e6883b187920e71ae57bbc9c07885afdd83ddc4e
Parent:     5047887caf1806f31652210df27fb62a7c43f27d
Author:     Sam Ravnborg <sam@ravnborg.org>
AuthorDate: Thu Jun 5 16:43:46 2008 +0200
Committer:  Sam Ravnborg <sam@ravnborg.org>
CommitDate: Fri Jul 25 22:08:37 2008 +0200

    kbuild: refactor headers_* targets in Makefile
    
    o Use lower case for local variables
    o Add a helper target for common targets
    o Use $(hdr-inst)= ... to make Make invocations simpler
    o Add -rR to make invocations
    
    In total this adds more lines than it removes but the
    benefit is better readability
    
    Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
    Cc: David Woodhouse <dwmw2@infradead.org>
---
 Makefile |   39 +++++++++++++++++++++++----------------
 1 files changed, 23 insertions(+), 16 deletions(-)

diff --git a/Makefile b/Makefile
index 4bcd1cf..f950661 100644
--- a/Makefile
+++ b/Makefile
@@ -1010,36 +1010,43 @@ firmware_install: FORCE
 
 # ---------------------------------------------------------------------------
 # Kernel headers
-INSTALL_HDR_PATH=$(objtree)/usr
-export INSTALL_HDR_PATH
 
-HDRFILTER=generic i386 x86_64
-HDRARCHES=$(filter-out $(HDRFILTER),$(patsubst $(srctree)/include/asm-%/Kbuild,%,$(wildcard $(srctree)/include/asm-*/Kbuild)))
+#Default location for installed headers
+export INSTALL_HDR_PATH = $(objtree)/usr
 
-PHONY += headers_install_all
-headers_install_all: include/linux/version.h scripts_basic FORCE
+hdr-filter := generic um ppc
+hdr-archs  := $(filter-out $(hdr-filter),                           \
+                  $(patsubst $(srctree)/include/asm-%/Kbuild,%,     \
+                      $(wildcard $(srctree)/include/asm-*/Kbuild)))
+hdr-inst := -rR -f $(srctree)/scripts/Makefile.headersinst obj
+
+PHONY += __headers
+__headers: include/linux/version.h scripts_basic FORCE
 ...
Previous thread: crypto: talitos - sparse fix by Linux Kernel Mailing List on Sunday, July 27, 2008 - 11:00 am. (1 message)

Next thread: kbuild: always unifdef files in headers_install* by Linux Kernel Mailing List on Sunday, July 27, 2008 - 11:00 am. (1 message)