__exit_signal: don't take rcu lock

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Friday, July 25, 2008 - 12:07 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3854a7...
Commit:     3854a771821c970065e3203a0b40ddc4101538cc
Parent:     100360f03077663b7bef3af44805b6cf700c3bee
Author:     Oleg Nesterov <oleg@tv-sign.ru>
AuthorDate: Fri Jul 25 01:47:29 2008 -0700
Committer:  Linus Torvalds <torvalds@linux-foundation.org>
CommitDate: Fri Jul 25 10:53:38 2008 -0700

    __exit_signal: don't take rcu lock
    
    There is no reason for rcu_read_lock() in __exit_signal().  tsk->sighand
    can only be changed if tsk does exec, obviously this is not possible.
    
    Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
    Cc: Roland McGrath <roland@redhat.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---
 kernel/exit.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/kernel/exit.c b/kernel/exit.c
index 93d2711..a7799d8 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -85,7 +85,6 @@ static void __exit_signal(struct task_struct *tsk)
 	BUG_ON(!sig);
 	BUG_ON(!atomic_read(&sig->count));
 
-	rcu_read_lock();
 	sighand = rcu_dereference(tsk->sighand);
 	spin_lock(&sighand->siglock);
 
@@ -136,7 +135,6 @@ static void __exit_signal(struct task_struct *tsk)
 	tsk->signal = NULL;
 	tsk->sighand = NULL;
 	spin_unlock(&sighand->siglock);
-	rcu_read_unlock();
 
 	__cleanup_sighand(sighand);
 	clear_tsk_thread_flag(tsk,TIF_SIGPENDING);
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
__exit_signal: don't take rcu lock, Linux Kernel Mailing ..., (Fri Jul 25, 12:07 pm)