MMC: S3C24XX: Refuse incorrectly aligned transfers

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Wednesday, July 16, 2008 - 4:21 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7e9c7b...
Commit:     7e9c7b64022b7faff6022df64baec8ab467d0bfd
Parent:     4dde7f755211fd58105c989a99a3a9f2f1238fba
Author:     Ben Dooks <ben-linux@fluff.org>
AuthorDate: Mon Jun 30 22:40:39 2008 +0100
Committer:  Pierre Ossman <drzeus@drzeus.cx>
CommitDate: Tue Jul 15 14:14:48 2008 +0200

    MMC: S3C24XX: Refuse incorrectly aligned transfers
    
    The hardware does not support any multi-block transfers
    with an block-size that is not 32bit aligned. Also the driver
    itself does not support single block non-32bit transfers
    either.
    
    Ensure that the s3cmci_setup_data() returns the appropriate
    error if we encounter this.
    
    Signed-off-by: Ben Dooks <ben-linux@fluff.org>
    Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
---
 drivers/mmc/host/s3cmci.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
index 2b48395..6a1e499 100644
--- a/drivers/mmc/host/s3cmci.c
+++ b/drivers/mmc/host/s3cmci.c
@@ -807,6 +807,17 @@ static int s3cmci_setup_data(struct s3cmci_host *host, struct mmc_data *data)
 		return 0;
 	}
 
+	if ((data->blksz & 3) != 0) {
+		/* We cannot deal with unaligned blocks with more than
+		 * one block being transfered. */
+
+		if (data->blocks > 1)
+			return -EINVAL;
+
+		/* No support yet for non-word block transfers. */
+		return -EINVAL;
+	}
+
 	while (readl(host->base + S3C2410_SDIDSTA) &
 	       (S3C2410_SDIDSTA_TXDATAON | S3C2410_SDIDSTA_RXDATAON)) {
 
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
MMC: S3C24XX: Refuse incorrectly aligned transfers, Linux Kernel Mailing ..., (Wed Jul 16, 4:21 pm)