MMC: S3C24XX: Fix s3c2410_dma_request() return code check.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Wednesday, July 16, 2008 - 4:20 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3886ff...
Commit:     3886ff5f63f33c801ed3af265ac0df20d3a8dcf5
Parent:     55d70f5a7b25800fc8376cdd81d42d6c201fa91d
Author:     Ben Dooks <ben-linux@fluff.org>
AuthorDate: Mon Jun 30 22:40:33 2008 +0100
Committer:  Pierre Ossman <drzeus@drzeus.cx>
CommitDate: Tue Jul 15 14:14:47 2008 +0200

    MMC: S3C24XX: Fix s3c2410_dma_request() return code check.
    
    The driver should be checking for a negative error code from
    s3c2410_dma_request(), not non-zero. Newer kernels now return
    the DMA channel number that was allocated by the request.
    
    Signed-off-by: Ben Dooks <ben-linux@fluff.org>
    Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
---
 drivers/mmc/host/s3cmci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
index aa9a8b4..8389107 100644
--- a/drivers/mmc/host/s3cmci.c
+++ b/drivers/mmc/host/s3cmci.c
@@ -1215,7 +1215,7 @@ static int __devinit s3cmci_probe(struct platform_device *pdev, int is2440)
 		s3c2410_gpio_cfgpin(host->pdata->gpio_wprotect,
 				    S3C2410_GPIO_INPUT);
 
-	if (s3c2410_dma_request(S3CMCI_DMA, &s3cmci_dma_client, NULL)) {
+	if (s3c2410_dma_request(S3CMCI_DMA, &s3cmci_dma_client, NULL) < 0) {
 		dev_err(&pdev->dev, "unable to get DMA channel.\n");
 		ret = -EBUSY;
 		goto probe_free_irq_cd;
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
MMC: S3C24XX: Fix s3c2410_dma_request() return code check., Linux Kernel Mailing ..., (Wed Jul 16, 4:20 pm)