sdhci-pci: don't penalize newer jmicron chips

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Wednesday, July 16, 2008 - 4:19 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=93fc48...
Commit:     93fc48c785f6266e67663b3cbbf24579b53fe5cf
Parent:     0121a9829bf28c65e1a05cc881899c10d82b8de2
Author:     Pierre Ossman <drzeus@drzeus.cx>
AuthorDate: Sat Jun 28 18:21:41 2008 +0200
Committer:  Pierre Ossman <drzeus@drzeus.cx>
CommitDate: Tue Jul 15 14:14:44 2008 +0200

    sdhci-pci: don't penalize newer jmicron chips
    
    The upcoming JMicron chips will have solved all the currently known
    bugs, so don't penalize them for older problems.
    
    Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
---
 drivers/mmc/host/sdhci-pci.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c
index c0fbf48..0716dcf 100644
--- a/drivers/mmc/host/sdhci-pci.c
+++ b/drivers/mmc/host/sdhci-pci.c
@@ -139,6 +139,12 @@ static int jmicron_probe(struct sdhci_pci_chip *chip)
 {
 	int ret;
 
+	if (chip->pdev->revision == 0) {
+		chip->quirks |= SDHCI_QUIRK_32BIT_DMA_ADDR |
+			  SDHCI_QUIRK_32BIT_DMA_SIZE |
+			  SDHCI_QUIRK_RESET_AFTER_REQUEST;
+	}
+
 	/*
 	 * JMicron chips can have two interfaces to the same hardware
 	 * in order to work around limitations in Microsoft's driver.
@@ -250,10 +256,6 @@ static int jmicron_resume(struct sdhci_pci_chip *chip)
 }
 
 static const struct sdhci_pci_fixes sdhci_jmicron = {
-	.quirks		= SDHCI_QUIRK_32BIT_DMA_ADDR |
-			  SDHCI_QUIRK_32BIT_DMA_SIZE |
-			  SDHCI_QUIRK_RESET_AFTER_REQUEST,
-
 	.probe		= jmicron_probe,
 
 	.probe_slot	= jmicron_probe_slot,
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
sdhci-pci: don't penalize newer jmicron chips, Linux Kernel Mailing ..., (Wed Jul 16, 4:19 pm)