powerpc: Implement OF PCI address accessors stubs for CONFIG_PCI=n

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Tuesday, July 15, 2008 - 8:11 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=ff1f4e...
Commit:     ff1f4ee94c3c4480b9cee95da2d19668262636c6
Parent:     9a24729d8aeef967eac7af71c6a69edc83d06558
Author:     Anton Vorontsov <avorontsov@ru.mvista.com>
AuthorDate: Wed Jun 11 08:31:00 2008 +1000
Committer:  Paul Mackerras <paulus@samba.org>
CommitDate: Mon Jun 30 22:30:51 2008 +1000

    powerpc: Implement OF PCI address accessors stubs for CONFIG_PCI=n
    
    To avoid "#ifdef CONFIG_PCI" in the drivers we should provide stubs in
    place of OF PCI address accessors.
    
    Without these stubs build breaks for drivers not strictly requiring PCI,
    for example CONFIG_FB_OF=y without CONFIG_PCI:
    
      LD      .tmp_vmlinux1
    drivers/built-in.o: In function `offb_map_reg':
    offb.c:(.text+0x6e7c): undefined reference to `of_get_pci_address'
    
    OF PCI IRQ accessors require pci_dev argument, so drivers using PCI
    IRQs should depend on CONFIG_PCI anyway.
    
    Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
    Signed-off-by: Paul Mackerras <paulus@samba.org>
---
 include/asm-powerpc/prom.h |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/include/asm-powerpc/prom.h b/include/asm-powerpc/prom.h
index 78b7b0d..eb3bd2e 100644
--- a/include/asm-powerpc/prom.h
+++ b/include/asm-powerpc/prom.h
@@ -212,8 +212,16 @@ extern u64 of_translate_dma_address(struct device_node *dev,
  */
 extern const u32 *of_get_address(struct device_node *dev, int index,
 			   u64 *size, unsigned int *flags);
+#ifdef CONFIG_PCI
 extern const u32 *of_get_pci_address(struct device_node *dev, int bar_no,
 			       u64 *size, unsigned int *flags);
+#else
+static inline const u32 *of_get_pci_address(struct device_node *dev,
+		int bar_no, u64 *size, unsigned int *flags)
+{
+	return NULL;
+}
+#endif /* CONFIG_PCI */
 
 /* Get an address as a resource. Note that if your address is
  * a PIO address, the conversion will fail if the physical address
@@ -223,8 +231,16 @@ extern const u32 *of_get_pci_address(struct device_node *dev, int bar_no,
  */
 extern int of_address_to_resource(struct device_node *dev, int index,
 				  struct resource *r);
+#ifdef CONFIG_PCI
 extern int of_pci_address_to_resource(struct device_node *dev, int bar,
 				      struct resource *r);
+#else
+static inline int of_pci_address_to_resource(struct device_node *dev, int bar,
+		struct resource *r)
+{
+	return -ENOSYS;
+}
+#endif /* CONFIG_PCI */
 
 /* Parse the ibm,dma-window property of an OF node into the busno, phys and
  * size parameters.
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
powerpc: Implement OF PCI address accessors stubs for CONF ..., Linux Kernel Mailing ..., (Tue Jul 15, 8:11 pm)