x86: don't use word-size specifiers.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Monday, July 14, 2008 - 3:59 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9aa038...
Commit:     9aa038815b5756e20a00b8e1efd5740434b37aea
Parent:     edf10162b2c5ad78ada8e63e960f9d0949c6c219
Author:     Glauber Costa <gcosta@redhat.com>
AuthorDate: Fri Jun 13 22:41:51 2008 -0300
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Wed Jul 9 09:14:00 2008 +0200

    x86: don't use word-size specifiers.
    
    Since the instructions refer to registers, they'll be able
    to figure it out.
    
    Signed-off-by: Glauber Costa <gcosta@redhat.com>
    Signed-off-by: H. Peter Anvin <hpa@zytor.com>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/lib/getuser_32.S |   24 ++++++++++++------------
 1 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/arch/x86/lib/getuser_32.S b/arch/x86/lib/getuser_32.S
index 6d84b53..8200fde 100644
--- a/arch/x86/lib/getuser_32.S
+++ b/arch/x86/lib/getuser_32.S
@@ -29,44 +29,44 @@
 ENTRY(__get_user_1)
 	CFI_STARTPROC
 	GET_THREAD_INFO(%edx)
-	cmpl TI_addr_limit(%edx),%eax
+	cmp TI_addr_limit(%edx),%eax
 	jae bad_get_user
-1:	movzbl (%eax),%edx
-	xorl %eax,%eax
+1:	movzb (%eax),%edx
+	xor %eax,%eax
 	ret
 	CFI_ENDPROC
 ENDPROC(__get_user_1)
 
 ENTRY(__get_user_2)
 	CFI_STARTPROC
-	addl $1,%eax
+	add $1,%eax
 	jc bad_get_user
 	GET_THREAD_INFO(%edx)
-	cmpl TI_addr_limit(%edx),%eax
+	cmp TI_addr_limit(%edx),%eax
 	jae bad_get_user
 2:	movzwl -1(%eax),%edx
-	xorl %eax,%eax
+	xor %eax,%eax
 	ret
 	CFI_ENDPROC
 ENDPROC(__get_user_2)
 
 ENTRY(__get_user_4)
 	CFI_STARTPROC
-	addl $3,%eax
+	add $3,%eax
 	jc bad_get_user
 	GET_THREAD_INFO(%edx)
-	cmpl TI_addr_limit(%edx),%eax
+	cmp TI_addr_limit(%edx),%eax
 	jae bad_get_user
-3:	movl -3(%eax),%edx
-	xorl %eax,%eax
+3:	mov -3(%eax),%edx
+	xor %eax,%eax
 	ret
 	CFI_ENDPROC
 ENDPROC(__get_user_4)
 
 bad_get_user:
 	CFI_STARTPROC
-	xorl %edx,%edx
-	movl $-14,%eax
+	xor %edx,%edx
+	mov $-14,%eax
 	ret
 	CFI_ENDPROC
 END(bad_get_user)
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
x86: don't use word-size specifiers., Linux Kernel Mailing ..., (Mon Jul 14, 3:59 pm)