USB: isp1760: Assign resource fields before adding hcd

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Wednesday, June 11, 2008 - 6:08 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e6942d...
Commit:     e6942d633be61f1638e08c56ab8244fc9f1c61e3
Parent:     62b5884875fcd4babf6c0c377046f226abbfe491
Author:     Nate Case <ncase@xes-inc.com>
AuthorDate: Wed May 21 16:28:20 2008 -0500
Committer:  Greg Kroah-Hartman <gregkh@suse.de>
CommitDate: Wed Jun 11 17:06:33 2008 -0700

    USB: isp1760: Assign resource fields before adding hcd
    
    This fixes the bogus "io mem 0x00000000" message printed
    during driver init due to hcd->rsrc_start being assigned after
    the call to usb_add_hcd().
    
    Signed-off-by: Nate Case <ncase@xes-inc.com>
    Acked-by: Sebastian Siewior <bigeasy@linutronix.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/usb/host/isp1760-hcd.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/host/isp1760-hcd.c b/drivers/usb/host/isp1760-hcd.c
index c9cec87..65aa5ec 100644
--- a/drivers/usb/host/isp1760-hcd.c
+++ b/drivers/usb/host/isp1760-hcd.c
@@ -2207,14 +2207,14 @@ struct usb_hcd *isp1760_register(u64 res_start, u64 res_len, int irq,
 		goto err_put;
 	}
 
-	ret = usb_add_hcd(hcd, irq, irqflags);
-	if (ret)
-		goto err_unmap;
-
 	hcd->irq = irq;
 	hcd->rsrc_start = res_start;
 	hcd->rsrc_len = res_len;
 
+	ret = usb_add_hcd(hcd, irq, irqflags);
+	if (ret)
+		goto err_unmap;
+
 	return hcd;
 
 err_unmap:
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
USB: isp1760: Assign resource fields before adding hcd, Linux Kernel Mailing ..., (Wed Jun 11, 6:08 pm)