qeth: Prepare-function to call s390dbf was wrong

Previous thread: qeth: reduce number of kernel messages by Linux Kernel Mailing List on Wednesday, June 11, 2008 - 6:02 pm. (1 message)

Next thread: qeth: start dev queue after tx drop error by Linux Kernel Mailing List on Wednesday, June 11, 2008 - 6:02 pm. (1 message)
From: Linux Kernel Mailing List
Date: Wednesday, June 11, 2008 - 6:02 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=345aa6...
Commit:     345aa66e97e61dccafaaa835e4b20d9b241e187f
Parent:     14cc21b6770972e5d1487dbf3a2caaf63cae909a
Author:     Peter Tiedemann <ptiedem@de.ibm.com>
AuthorDate: Fri Jun 6 12:37:47 2008 +0200
Committer:  Jeff Garzik <jgarzik@redhat.com>
CommitDate: Tue Jun 10 18:20:36 2008 -0400

    qeth: Prepare-function to call s390dbf was wrong
    
    Prepare-function to call s390dbf was wrong handling variable arguments.
    This worked as macro but not as function any more.
    Now using va_list processing.
    
    Signed-off-by: Peter Tiedemann <ptiedem@de.ibm.com>
    Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
    Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
 drivers/s390/net/qeth_core_main.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
index f428d75..9a71dae 100644
--- a/drivers/s390/net/qeth_core_main.c
+++ b/drivers/s390/net/qeth_core_main.c
@@ -3983,15 +3983,17 @@ static void qeth_unregister_dbf_views(void)
 	}
 }
 
-void qeth_dbf_longtext(enum qeth_dbf_names dbf_nix, int level, char *text, ...)
+void qeth_dbf_longtext(enum qeth_dbf_names dbf_nix, int level, char *fmt, ...)
 {
 	char dbf_txt_buf[32];
+	va_list args;
 
 	if (level > (qeth_dbf[dbf_nix].id)->level)
 		return;
-	snprintf(dbf_txt_buf, sizeof(dbf_txt_buf), text);
+	va_start(args, fmt);
+	vsnprintf(dbf_txt_buf, sizeof(dbf_txt_buf), fmt, args);
+	va_end(args);
 	debug_text_event(qeth_dbf[dbf_nix].id, level, dbf_txt_buf);
-	
 }
 EXPORT_SYMBOL_GPL(qeth_dbf_longtext);
 
--

Previous thread: qeth: reduce number of kernel messages by Linux Kernel Mailing List on Wednesday, June 11, 2008 - 6:02 pm. (1 message)

Next thread: qeth: start dev queue after tx drop error by Linux Kernel Mailing List on Wednesday, June 11, 2008 - 6:02 pm. (1 message)