Fix drivers/media build for modular builds

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <git-commits-head@...>
Date: Thursday, May 8, 2008 - 5:59 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f7c83a...
Commit:     f7c83a0aaa772f8d0189fa197d77c762caaa367a
Parent:     8e1bf9ffb1aca693e3cf4a4f7144c8f70c8a08b0
Author:     Ingo Molnar <mingo@elte.hu>
AuthorDate: Wed Apr 30 09:48:07 2008 +0200
Committer:  Linus Torvalds <torvalds@linux-foundation.org>
CommitDate: Thu May 8 10:55:23 2008 -0700

    Fix drivers/media build for modular builds
    
    Fix allmodconfig build bug introduced in latest -git by commit
    7c91f0624a9 ("V4L/DVB(7767): Move tuners to common/tuners"):
    
      LD      kernel/built-in.o
      LD      drivers/built-in.o
      ld: drivers/media/built-in.o: No such file: No such file or directory
    
    which happens if all media drivers are modular:
    
      http://redhat.com/~mingo/misc/config-Wed_Apr_30_09_24_48_CEST_2008.bad
    
    In that case there's no obj-y rule connecting all the built-in.o files and
    the link tree breaks.
    
    The fix is to add a guaranteed obj-y rule for the core vmlinux to build.
    (which results in an empty object file if all media drivers are modular)
    
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    Acked-by: Sam Ravnborg <sam@ravnborg.org>
    Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---
 drivers/media/Makefile |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/media/Makefile b/drivers/media/Makefile
index 73f742c..cc11c4c 100644
--- a/drivers/media/Makefile
+++ b/drivers/media/Makefile
@@ -2,6 +2,8 @@
 # Makefile for the kernel multimedia device drivers.
 #
 
+obj-y := common/
+
 obj-$(CONFIG_VIDEO_MEDIA) += common/
 
 # Since hybrid devices are here, should be compiled if DVB and/or V4L
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Fix drivers/media build for modular builds, Linux Kernel Mailing List..., (Thu May 8, 5:59 pm)