IB/ipath: Only warn about prototype chip during init

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <git-commits-head@...>
Date: Thursday, May 8, 2008 - 5:59 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=5f51ef...
Commit:     5f51efc195dfb860c60fafb4e47fe4b7cad2626d
Parent:     273748cc908a901d082b4da5a16b2541c9d78a02
Author:     Michael Albaugh <Michael.Albaugh@Qlogic.com>
AuthorDate: Wed May 7 10:56:47 2008 -0700
Committer:  Roland Dreier <rolandd@cisco.com>
CommitDate: Wed May 7 10:56:47 2008 -0700

    IB/ipath: Only warn about prototype chip during init
    
    We warn about prototype chips, but the function that checks for
    support is also called as a result of a get_portinfo request, which
    can clutter the logs.
    
    Restrict warning to only appear during initialization.
    
    Signed-off-by: Michael Albaugh <michael.albaugh@qlogic.com>
    Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
 drivers/infiniband/hw/ipath/ipath_iba7220.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/ipath/ipath_iba7220.c b/drivers/infiniband/hw/ipath/ipath_iba7220.c
index e3ec0d1..5f693de 100644
--- a/drivers/infiniband/hw/ipath/ipath_iba7220.c
+++ b/drivers/infiniband/hw/ipath/ipath_iba7220.c
@@ -870,8 +870,9 @@ static int ipath_7220_boardname(struct ipath_devdata *dd, char *name,
 			      "revision %u.%u!\n",
 			      dd->ipath_majrev, dd->ipath_minrev);
 		ret = 1;
-	} else if (dd->ipath_minrev == 1) {
-		/* Rev1 chips are prototype. Complain, but allow use */
+	} else if (dd->ipath_minrev == 1 &&
+		!(dd->ipath_flags & IPATH_INITTED)) {
+		/* Rev1 chips are prototype. Complain at init, but allow use */
 		ipath_dev_err(dd, "Unsupported hardware "
 			      "revision %u.%u, Contact support@qlogic.com\n",
 			      dd->ipath_majrev, dd->ipath_minrev);
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
IB/ipath: Only warn about prototype chip during init, Linux Kernel Mailing List..., (Thu May 8, 5:59 pm)