lguest: remove bogus NULL cpu check

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Friday, May 2, 2008 - 9:59 am

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9f3f74...
Commit:     9f3f746741d917fe3c6c544c7d319d533176d90b
Parent:     24adf12722b4f2800e5b5f0955d57033f0d0c9e5
Author:     Rusty Russell <rusty@rustcorp.com.au>
AuthorDate: Fri May 2 21:50:51 2008 -0500
Committer:  Rusty Russell <rusty@rustcorp.com.au>
CommitDate: Fri May 2 21:50:52 2008 +1000

    lguest: remove bogus NULL cpu check
    
    If lg isn't NULL, and cpu_id is sane, &lg->cpus[cpu_id] can't be NULL.
    
    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
 drivers/lguest/lguest_user.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/lguest/lguest_user.c b/drivers/lguest/lguest_user.c
index 4017701..e73a000 100644
--- a/drivers/lguest/lguest_user.c
+++ b/drivers/lguest/lguest_user.c
@@ -251,8 +251,6 @@ static ssize_t write(struct file *file, const char __user *in,
 		if (!lg || (cpu_id >= lg->nr_cpus))
 			return -EINVAL;
 		cpu = &lg->cpus[cpu_id];
-		if (!cpu)
-			return -EINVAL;
 
 		/* Once the Guest is dead, you can only read() why it died. */
 		if (lg->dead)
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
lguest: remove bogus NULL cpu check, Linux Kernel Mailing ..., (Fri May 2, 9:59 am)