Home » Mailing list archives » git-commits-head » 2008 » April » 26

x86, bitops: select the generic bitmap search functions

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Linux Kernel Mailing List <linux-kernel@...>
To: <git-commits-head@...>
Subject: x86, bitops: select the generic bitmap search functions
Date: Saturday, April 26, 2008 - 6:01 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=19870d...
Commit:     19870def587554c4055df3e74a21508e3647fb7e
Parent:     f19dcf4a61ea4a3d155acb239348d09cb264f6a0
Author:     Alexander van Heukelum <heukelum@mailshack.com>
AuthorDate: Fri Apr 25 13:12:53 2008 +0200
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Sat Apr 26 19:21:17 2008 +0200

    x86, bitops: select the generic bitmap search functions
    
    Introduce GENERIC_FIND_FIRST_BIT and GENERIC_FIND_NEXT_BIT in
    lib/Kconfig, defaulting to off. An arch that wants to use the
    generic implementation now only has to use a select statement
    to include them.
    
    I added an always-y option (X86_CPU) to arch/x86/Kconfig.cpu
    and used that to select the generic search functions. This
    way ARCH=um SUBARCH=i386 automatically picks up the change
    too, and arch/um/Kconfig.i386 can therefore be simplified a
    bit. ARCH=um SUBARCH=x86_64 does things differently, but
    still compiles fine. It seems that a "def_bool y" always
    wins over a "def_bool n"?
    
    Signed-off-by: Alexander van Heukelum <heukelum@fastmail.fm>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/um/Kconfig.i386   |    8 --------
 arch/um/Kconfig.x86_64 |    8 --------
 arch/x86/Kconfig       |    6 ------
 arch/x86/Kconfig.cpu   |    5 +++++
 lib/Kconfig            |    6 ++++++
 5 files changed, 11 insertions(+), 22 deletions(-)

diff --git a/arch/um/Kconfig.i386 b/arch/um/Kconfig.i386
index 49990ea..e09edfa 100644
--- a/arch/um/Kconfig.i386
+++ b/arch/um/Kconfig.i386
@@ -39,14 +39,6 @@ config ARCH_REUSE_HOST_VSYSCALL_AREA
 	bool
 	default y
 
-config GENERIC_FIND_FIRST_BIT
-	bool
-	default y
-
-config GENERIC_FIND_NEXT_BIT
-	bool
-	default y
-
 config GENERIC_HWEIGHT
 	bool
 	default y
diff --git a/arch/um/Kconfig.x86_64 b/arch/um/Kconfig.x86_64
index cc42e59..5696e7b 100644
--- a/arch/um/Kconfig.x86_64
+++ b/arch/um/Kconfig.x86_64
@@ -34,14 +34,6 @@ config SMP_BROKEN
 	bool
 	default y
 
-config GENERIC_FIND_FIRST_BIT
-	bool
-	default y
-
-config GENERIC_FIND_NEXT_BIT
-	bool
-	default y
-
 config GENERIC_HWEIGHT
 	bool
 	default y
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 7004477..2fadf79 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -77,12 +77,6 @@ config GENERIC_BUG
 	def_bool y
 	depends on BUG
 
-config GENERIC_FIND_FIRST_BIT
-	def_bool y
-
-config GENERIC_FIND_NEXT_BIT
-	def_bool y
-
 config GENERIC_HWEIGHT
 	def_bool y
 
diff --git a/arch/x86/Kconfig.cpu b/arch/x86/Kconfig.cpu
index cf3ff2c..7ef18b0 100644
--- a/arch/x86/Kconfig.cpu
+++ b/arch/x86/Kconfig.cpu
@@ -278,6 +278,11 @@ config GENERIC_CPU
 
 endchoice
 
+config X86_CPU
+	def_bool y
+	select GENERIC_FIND_FIRST_BIT
+	select GENERIC_FIND_NEXT_BIT
+
 config X86_GENERIC
 	bool "Generic x86 support"
 	depends on X86_32
diff --git a/lib/Kconfig b/lib/Kconfig
index 2d53dc0..8cc8e87 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -7,6 +7,12 @@ menu "Library routines"
 config BITREVERSE
 	tristate
 
+config GENERIC_FIND_FIRST_BIT
+	def_bool n
+
+config GENERIC_FIND_NEXT_BIT
+	def_bool n
+
 config CRC_CCITT
 	tristate "CRC-CCITT functions"
 	help
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
x86, bitops: select the generic bitmap search functions, Linux Kernel Mailing List..., (Sat Apr 26, 6:01 pm)