Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=651be3...
Commit:     651be3a2ba95bc30fcb737985741736e63231cdf
Parent:     d785ad74641c59074786084b24a9283d7a7727b0
Author:     Adrian Bunk <bunk@kernel.org>
AuthorDate: Sat Feb 2 23:15:02 2008 +0200
Committer:  Jeff Garzik <jeff@garzik.org>
CommitDate: Mon Feb 11 11:15:36 2008 -0500

    net/phy/fixed.c: fix a use-after-free
    
    This patch fixes a use-after-free introduced by
    commit a79d8e93d300adb84cccc38ac396cfb118c238ad and spotted by the
    Coverity checker.
    
    Signed-off-by: Adrian Bunk <bunk@kernel.org>
    Signed-off-by: Jeff Garzik <jeff@garzik.org>
---
 drivers/net/phy/fixed.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/fixed.c b/drivers/net/phy/fixed.c
index 73b6d39..ca9b040 100644
--- a/drivers/net/phy/fixed.c
+++ b/drivers/net/phy/fixed.c
@@ -236,12 +236,12 @@ module_init(fixed_mdio_bus_init);
 static void __exit fixed_mdio_bus_exit(void)
 {
 	struct fixed_mdio_bus *fmb = &platform_fmb;
-	struct fixed_phy *fp;
+	struct fixed_phy *fp, *tmp;
 
 	mdiobus_unregister(&fmb->mii_bus);
 	platform_device_unregister(pdev);
 
-	list_for_each_entry(fp, &fmb->phys, node) {
+	list_for_each_entry_safe(fp, tmp, &fmb->phys, node) {
 		list_del(&fp->node);
 		kfree(fp);
 	}
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html