powerpc/mpc5200: Bestcomm fixes to ATA support

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Sunday, December 28, 2008 - 6:05 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e4efe3...
Commit:     e4efe3c271c5498ffe7e167eaff01514be2b9a77
Parent:     622882455aa718cfbd6785cc5fbc479f1d976095
Author:     Tim Yamin <plasm@roo.me.uk>
AuthorDate: Sun Dec 21 02:54:28 2008 -0700
Committer:  Grant Likely <grant.likely@secretlab.ca>
CommitDate: Sun Dec 21 02:54:28 2008 -0700

    powerpc/mpc5200: Bestcomm fixes to ATA support
    
    1) ata.h has dst_pa in the wrong place (needs to match what the BestComm
       task microcode in bcom_ata_task.c expects); fix it.
    
    2) The BestComm ATA task priority was changed to maximum in bestcomm_priv.h;
       this fixes a deadlock issue experienced with heavy DMA occurring on
       both the ATA and Ethernet BestComm tasks, e.g. when downloading a large
       file over a LAN to disk.
    
    Signed-off-by: Tim Yamin <plasm@roo.me.uk>
    Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
 arch/powerpc/sysdev/bestcomm/ata.h           |    2 +-
 arch/powerpc/sysdev/bestcomm/bestcomm_priv.h |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/sysdev/bestcomm/ata.h b/arch/powerpc/sysdev/bestcomm/ata.h
index 1098276..0374322 100644
--- a/arch/powerpc/sysdev/bestcomm/ata.h
+++ b/arch/powerpc/sysdev/bestcomm/ata.h
@@ -16,8 +16,8 @@
 
 struct bcom_ata_bd {
 	u32	status;
-	u32	dst_pa;
 	u32	src_pa;
+	u32	dst_pa;
 };
 
 extern struct bcom_task *
diff --git a/arch/powerpc/sysdev/bestcomm/bestcomm_priv.h b/arch/powerpc/sysdev/bestcomm/bestcomm_priv.h
index 866a291..746f155 100644
--- a/arch/powerpc/sysdev/bestcomm/bestcomm_priv.h
+++ b/arch/powerpc/sysdev/bestcomm/bestcomm_priv.h
@@ -198,8 +198,8 @@ struct bcom_task_header {
 #define BCOM_IPR_SCTMR_1	2
 #define BCOM_IPR_FEC_RX		6
 #define BCOM_IPR_FEC_TX		5
-#define BCOM_IPR_ATA_RX		4
-#define BCOM_IPR_ATA_TX		3
+#define BCOM_IPR_ATA_RX		7
+#define BCOM_IPR_ATA_TX		7
 #define BCOM_IPR_SCPCI_RX	2
 #define BCOM_IPR_SCPCI_TX	2
 #define BCOM_IPR_PSC3_RX	2
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
powerpc/mpc5200: Bestcomm fixes to ATA support, Linux Kernel Mailing ..., (Sun Dec 28, 6:05 pm)