powerpc: Remove superfluous WARN_ON() from dma-noncoherent.c

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Sunday, December 28, 2008 - 6:01 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7526ff...
Commit:     7526ff76f84178f8c926de7e590e4c5f9d4a2e62
Parent:     efc3624c9419cad3cca93dfabb7b12664773d2b1
Author:     Hollis Blanchard <hollisb@us.ibm.com>
AuthorDate: Mon Nov 10 14:33:36 2008 +0000
Committer:  Paul Mackerras <paulus@samba.org>
CommitDate: Wed Nov 19 16:04:52 2008 +1100

    powerpc: Remove superfluous WARN_ON() from dma-noncoherent.c
    
    I can't tell why this WARN_ON exists, and there's no comment
    explaining it.  Whether the pmd is present or not, pte_alloc_kernel()
    seems to handle both cases.
    
    Booting a 440 kernel with 64K PAGE_SIZE triggers the warning, but boot
    successfully completes and I see no problems beyond that.
    
    Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
    Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Signed-off-by: Paul Mackerras <paulus@samba.org>
---
 arch/powerpc/lib/dma-noncoherent.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/lib/dma-noncoherent.c b/arch/powerpc/lib/dma-noncoherent.c
index 31734c0..2b1ce18 100644
--- a/arch/powerpc/lib/dma-noncoherent.c
+++ b/arch/powerpc/lib/dma-noncoherent.c
@@ -320,7 +320,6 @@ static int __init dma_alloc_init(void)
 			ret = -ENOMEM;
 			break;
 		}
-		WARN_ON(!pmd_none(*pmd));
 
 		pte = pte_alloc_kernel(pmd, CONSISTENT_BASE);
 		if (!pte) {
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
powerpc: Remove superfluous WARN_ON() from dma-noncoherent.c, Linux Kernel Mailing ..., (Sun Dec 28, 6:01 pm)