fsl_usb2_udc: Add a wmb before priming endpoint.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Friday, October 17, 2008 - 5:06 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=59097f...
Commit:     59097fb73cf60276053551308524f6c772f305a9
Parent:     224b50390104af7602871894540d94cc759dc4c0
Author:     Will Newton <will.newton@gmail.com>
AuthorDate: Tue Aug 12 15:39:16 2008 +0100
Committer:  Greg Kroah-Hartman <gregkh@suse.de>
CommitDate: Fri Oct 17 14:41:07 2008 -0700

    fsl_usb2_udc: Add a wmb before priming endpoint.
    
    Add a wmb to fsl_queue_td before priming the endpoint. This ensures that the
    modifications to the QH are seen by the hardware.
    
    Added comment as suggested by Felipe Balbi.
    
    Signed-off-by: Will Newton <will.newton@gmail.com>
    Acked-by: Li Yang <leoli@freescale.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/usb/gadget/fsl_usb2_udc.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/gadget/fsl_usb2_udc.c b/drivers/usb/gadget/fsl_usb2_udc.c
index 6f62720..0492441 100644
--- a/drivers/usb/gadget/fsl_usb2_udc.c
+++ b/drivers/usb/gadget/fsl_usb2_udc.c
@@ -643,6 +643,9 @@ static void fsl_queue_td(struct fsl_ep *ep, struct fsl_req *req)
 			| EP_QUEUE_HEAD_STATUS_HALT));
 	dQH->size_ioc_int_sts &= temp;
 
+	/* Ensure that updates to the QH will occure before priming. */
+	wmb();
+
 	/* Prime endpoint by writing 1 to ENDPTPRIME */
 	temp = ep_is_in(ep)
 		? (1 << (ep_index(ep) + 16))
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
fsl_usb2_udc: Add a wmb before priming endpoint., Linux Kernel Mailing ..., (Fri Oct 17, 5:06 pm)