fsl_usb2_udc: Remove check for udc == NULL in dr_controller_setup.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Friday, October 17, 2008 - 5:06 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f6e441...
Commit:     f6e4411fe7df19493e3a2fbc2543f718f75671f6
Parent:     9c94155ea03e85aed66b6822477ea99f8681a3f1
Author:     Will Newton <will.newton@imgtec.com>
AuthorDate: Tue Aug 12 15:39:08 2008 +0100
Committer:  Greg Kroah-Hartman <gregkh@suse.de>
CommitDate: Fri Oct 17 14:41:05 2008 -0700

    fsl_usb2_udc: Remove check for udc == NULL in dr_controller_setup.
    
    Remove check for udc == NULL in dr_controller_setup. All callers of
    this function have already dereferenced udc at some point.
    
    Signed-off-by: Will Newton <will.newton@gmail.com>
    Acked-by: Li Yang <leoli@freescale.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/usb/gadget/fsl_usb2_udc.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/gadget/fsl_usb2_udc.c b/drivers/usb/gadget/fsl_usb2_udc.c
index d140e1b..3b96aac 100644
--- a/drivers/usb/gadget/fsl_usb2_udc.c
+++ b/drivers/usb/gadget/fsl_usb2_udc.c
@@ -185,10 +185,6 @@ static int dr_controller_setup(struct fsl_udc *udc)
 	unsigned long timeout;
 #define FSL_UDC_RESET_TIMEOUT 1000
 
-	/* before here, make sure dr_regs has been initialized */
-	if (!udc)
-		return -EINVAL;
-
 	/* Stop and reset the usb controller */
 	tmp = fsl_readl(&dr_regs->usbcmd);
 	tmp &= ~USB_CMD_RUN_STOP;
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
fsl_usb2_udc: Remove check for udc == NULL in dr_controlle ..., Linux Kernel Mailing ..., (Fri Oct 17, 5:06 pm)