rtc: file close() consistently disables repeating irqs

Previous thread: rtc: rtc-rs5c372: add support for Ricoh R2025S/D RTC by Linux Kernel Mailing List on Thursday, October 16, 2008 - 12:04 pm. (1 message)

Next thread: rtc: use CONFIG_PPC instead of CONFIG_PPC_MERGE by Linux Kernel Mailing List on Thursday, October 16, 2008 - 12:04 pm. (1 message)
From: Linux Kernel Mailing List
Date: Thursday, October 16, 2008 - 12:04 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=743e6a...
Commit:     743e6a504f81d1e2f086e726b69fb6631d11f820
Parent:     37fc5e2c42833c32f7c8eb5d9b3a3115bb37d9c3
Author:     David Brownell <dbrownell@users.sourceforge.net>
AuthorDate: Wed Oct 15 22:03:04 2008 -0700
Committer:  Linus Torvalds <torvalds@linux-foundation.org>
CommitDate: Thu Oct 16 11:21:40 2008 -0700

    rtc: file close() consistently disables repeating irqs
    
    Make the rtc framework consistent about disabling 1/second update IRQs
    that may have been activated through the /dev interface, when that /dev
    file is closed.  (It may have closed because of coredump, etc.) This was
    previously done only for emulated update IRQs ...  now, do it always.
    
    Also comment the current policy: repeating IRQs (periodic, update) that
    userspace enabled will be cleanly disabled, but alarms are left alone.
    Such repeating IRQs are a constant and pointless system load.
    
    Update some RTC drivers to remove now-needless release() methods.  Most
    such methods just enforce that policy.  The others all seem to be buggy,
    and mistreat in-kernel clients of periodic or alarm IRQs.
    
    Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
    Acked-by: Andrew Sharp <andy.sharp@onstor.com>
    Cc: Angelo Castello <angelo.castello@st.com>
    Acked-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
    Acked-by: Paul Mundt <lethal@linux-sh.org>
    Cc: Thomas Hommel <thomas.hommel@gefanuc.com>
    Acked-by: Alessandro Zummo <a.zummo@towertech.it>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---
 drivers/rtc/rtc-dev.c      |   12 +++++++++---
 drivers/rtc/rtc-ds1511.c   |   13 -------------
 drivers/rtc/rtc-ds1553.c   |   12 ------------
 drivers/rtc/rtc-sh.c       |    7 -------
 drivers/rtc/rtc-stk17ta8.c |   12 ------------
 5 files ...
Previous thread: rtc: rtc-rs5c372: add support for Ricoh R2025S/D RTC by Linux Kernel Mailing List on Thursday, October 16, 2008 - 12:04 pm. (1 message)

Next thread: rtc: use CONFIG_PPC instead of CONFIG_PPC_MERGE by Linux Kernel Mailing List on Thursday, October 16, 2008 - 12:04 pm. (1 message)