Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=6c5e51...
Commit:     6c5e51dae2c37127e00be392f40842e08077e96a
Parent:     eae82541cf62cd8b585377d799335b8f9a701c4a
Author:     Christoph Hellwig <hch@lst.de>
AuthorDate: Sun Oct 12 14:30:44 2008 +0200
Committer:  Linus Torvalds <torvalds@linux-foundation.org>
CommitDate: Wed Oct 15 10:00:00 2008 -0700

    xfs: fix remount rw with unrecognized options
    
    When we skip unrecognized options in xfs_fs_remount we should just break
    out of the switch and not return because otherwise we may skip clearing
    the xfs-internal read-only flag.  This will only show up on some
    operations like touch because most read-only checks are done by the VFS
    which thinks this filesystem is r/w.  Eventually we should replace the
    XFS read-only flag with a helper that always checks the VFS flag to make
    sure they can never get out of sync.
    
    Bug reported and fix verified by Marcel Beister on #xfs.
    Bug fix verified by updated xfstests/189.
    
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Acked-by: Eric Sandeen <sandeen@sandeen.net>
    Signed-off-by: Timothy Shimmin <tes@sgi.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---
 fs/xfs/linux-2.6/xfs_super.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/xfs_super.c
index 7227b2e..e390136 100644
--- a/fs/xfs/linux-2.6/xfs_super.c
+++ b/fs/xfs/linux-2.6/xfs_super.c
@@ -1323,7 +1323,7 @@ xfs_fs_remount(
 	"XFS: mount option \"%s\" not supported for remount\n", p);
 			return -EINVAL;
 #else
-			return 0;
+			break;
 #endif
 		}
 	}
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html