x86-64: fix combining of regions in init_memory_mapping()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Monday, October 13, 2008 - 11:07 am

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=5e72d9...
Commit:     5e72d9e4850c91b6a0f06fa803f7393b55a38aa8
Parent:     59ef48a58e59cc27255d526ae3fa60ddcd977208
Author:     Jan Beulich <jbeulich@novell.com>
AuthorDate: Fri Sep 12 15:43:04 2008 +0100
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Mon Oct 13 10:21:16 2008 +0200

    x86-64: fix combining of regions in init_memory_mapping()
    
    When nr_range gets decremented, the same slot must be considered for
    coalescing with its new successor again.
    
    The issue is apparently pretty benign to native code, but surfaces as a
    boot time crash in our forward ported Xen tree (where the page table
    setup overall works differently than in native).
    
    Signed-off-by: Jan Beulich <jbeulich@novell.com>
    Acked-by: Yinghai Lu <yhlu.kernel@gmail.com>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/mm/init_64.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index 7c8bb46..b8e461d 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -746,7 +746,7 @@ unsigned long __init_refok init_memory_mapping(unsigned long start,
 		old_start = mr[i].start;
 		memmove(&mr[i], &mr[i+1],
 			 (nr_range - 1 - i) * sizeof (struct map_range));
-		mr[i].start = old_start;
+		mr[i--].start = old_start;
 		nr_range--;
 	}
 
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
x86-64: fix combining of regions in init_memory_mapping(), Linux Kernel Mailing ..., (Mon Oct 13, 11:07 am)